fix(runtime-wry): window edge not working after setting resizable false and decorated false dynamically #10211
Conversation
after setting resziable false and decorated false dynamically
|
I'm not sure if we also want to disable it on fullscreen and maximize or is it something the user should do manually |
I think we used to do that 🤔 |
|
Looking at the code it seems to be handled by amr's code already, |
| "tauri-runtime-wry": "patch:bug" | ||
| --- | ||
|
|
||
| Fix window edge not working after setting resizable false and decorated false dynamically |
There was a problem hiding this comment.
I am not sure I understand the problem, if decoration is false and resizable is false, window edge should not work
There was a problem hiding this comment.
Shouldn't the edges of an undercoated window with resize disabled receive events and being clickable?
There was a problem hiding this comment.
yeah it should, is it not receiving these events?
There was a problem hiding this comment.
no, that part is blocked by the top level resize window and not interactable at all
There was a problem hiding this comment.
ah I see where the bug is, I will push a better fix
There was a problem hiding this comment.
@Legend-Master could you give 14af33b a test?
There was a problem hiding this comment.
Doesn't seem to work, after setting both resize and decoration to false, the entire window becomes not interactable
There was a problem hiding this comment.
I retested and seemed like I can click just fine, outside and inside the resize region.
There was a problem hiding this comment.
nvm, I was mislead by the hover effect, I reverted my changes
There was a problem hiding this comment.
kinda weird that HTTRANSPARENT didn't work, will need to research it more I guess. Your solution is fine for now.
amrbashir
force-pushed
the
resize-false-undecorated
branch
from
e0725d0
to
7634cd7
Compare
Not sure if it's related with #10205