`beforeDevCommand` is not killed on app exit #2794

harshkhandeparkar · 2021-10-23T16:24:51Z

Describe the bug

Closing the tauri dev app window doesn't close the dev server started with beforeDevCommand (confirmed using the create-react-app template for create-tauri-app)

To Reproduce

Steps to reproduce the behavior:

Create an app using create-react-app template
Run tauri dev
Close the app window using the x button or alt + f4
Run tauri dev again.

Expected behavior

The dev server should be gracefully shut down when the app is closed.

The text was updated successfully, but these errors were encountered:

rondonjon · 2021-10-27T07:27:19Z

gracefully shut down

Gracefully or not, please terminate the darn process :-)

I cannot reproduce the behavior reliably. Sometimes the dev server gets shut down, sometimes it keeps running. This is esepcially annoying while debugging: trying to force the app to do something, wondering why the app is acting so strange and then realizing a few minutes later that none of the code changes were actually deployed.

frnco · 2021-11-13T02:06:44Z

Gracefully or not, please terminate the darn process :-)
Couldn't agree more.

I cannot reproduce the behavior reliably. Sometimes the dev server gets shut down, sometimes it keeps running. This is esepcially annoying while debugging: trying to force the app to do something, wondering why the app is acting so strange and then realizing a few minutes later that none of the code changes were actually deployed.
For me the beforeDevCommand always closes properly, I'm on Arch Linux and mostly using Mint, not React, but that means there are some conditions for this problem to happen. To add some info on my system so it may help figure out what's different, it's Arch Linux, x64, I'm running tauri from cargo(i.e. cargo tauri dev), and I started a bunch of small projects using Tauri to test different combinations, which means I've had a lot (And I mean A LOT) of stuff on beforeDevCommand, never had any problem, all of the commands closed properly when I exited the Tauri app, some of the commands I can recall were vite for running VueJS, mint, elm... There were so many things I don't even remember it all. I'll check React later and report here just for completeness.

And as this points to something specific being necessary to trigger this failure in terminating the child process, I believe some tauri info would be nice here, or at least the OS and what the beforeDevCommand actually runs.

lucasfernog · 2021-11-13T16:40:06Z

I couldn't reproduce this one yet, can one of you see if #2883 fixes it?
I assume this is on Windows so that's what i'm testing, no one pasted a tauri info output.

SeedyROM · 2022-03-01T07:53:14Z

@lucasfernog Here's my tauri info for the same issue, I consistently get this bug.

Operating System - Manjaro, version 21.2.2 X64

Node.js environment
  Node.js - 16.13.2
  @tauri-apps/cli - 1.0.0-rc.5
  @tauri-apps/api - 1.0.0-rc.1

Global packages
  npm - 8.3.0
  pnpm - 6.23.3
  yarn - 1.22.15

Rust environment
  rustup - 1.24.3
  rustc - 1.60.0-nightly
  cargo - 1.60.0-nightly
  toolchain - nightly-x86_64-unknown-linux-gnu 

App directory structure
/src
/node_modules
/build
/public
/src-tauri

App
  tauri - 1.0.0-rc.3 (no lockfile)
  tauri-build - no manifest (no lockfile)
  tao - no manifest (no lockfile)
  wry - no manifest (no lockfile)
  build-type - bundle
  CSP - unset
  distDir - ../build
  devPath - http://localhost:3000/
  framework - React

Janaka-Steph · 2022-03-01T09:25:12Z

I also always got it.

▶ cargo tauri info

Operating System - Mac OS, version 12.2.1 X64

Node.js environment
Node.js - 16.14.0
@tauri-apps/cli - 1.0.0-rc.5
@tauri-apps/api - 1.0.0-rc.1

Global packages
npm - 8.1.4
pnpm - Not installed
yarn - 1.22.17

Rust environment
rustup - 1.24.3
rustc - 1.58.1
cargo - 1.58.0
toolchain - stable-aarch64-apple-darwin

App directory structure
/node_modules
/public
/scripts
/.github
/src-tauri
/build
/.git
/.idea
/src

App
tauri - 1.0.0-rc.3
tauri-build - 1.0.0-rc.3
tao - 0.6.2
wry - 0.13.2
build-type - bundle
CSP - default-src blob: data: filesystem: ws: wss: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'
distDir - ../build
devPath - http://localhost:3003/
framework - React
bundler - Webpack

nothingismagick · 2022-03-01T09:33:34Z

So this does seem to look like a react issue. I think we should go through and verify other non-"reacty" frameworks and see if its just particular here, or relevant for others.

FabianLars · 2022-03-01T09:51:11Z

It is a general problem, it's just worse with some frameworks/bundlers. For example i have the same problem with vitejs (no matter the frontend), but only if i close the app with ctrl+c. This also renders the terminal completely unusable for me.

JonasKruckenberg · 2022-03-01T10:39:03Z

As a workaround (and good practice in general) for those who use vite, here's the config we will be recommending in the guides:

{
  // prevent vite from obscuring rust errors
  clearScreen: false,
  // tauri expects a fixed port, fail if that port is not available
  server: {
    port: 3000,
    strictPort: true,
  },
  // to make use of `TAURI_PLATFORM`, `TAURI_ARCH`, `TAURI_FAMILY`, `TAURI_PLATFORM_VERSION`, `TAURI_PLATFORM_TYPE` and `TAURI_DEBUG` env variables
  envPrefix: ['VITE_', 'TAURI_'],
  build: {
    // tauri supports es2021
    target: ['es2021', 'chrome97', 'safari13'],
    // don't minify for debug builds
    minify: !process.env.TAURI_DEBUG && 'esbuild',
    // produce sourcemaps for debug builds
    sourcemap: !!process.env.TAURI_DEBUG,
  },
}

The important settings for this issue are these:

  // Fixes the console override issue
  clearScreen: false,
  // makes vite abort if orphan processes keep port 3000 occupied
  server: {
    port: 3000,
    strictPort: true,
  },

nothingismagick · 2022-03-01T10:57:09Z

There is another approach in bash, where you can grab the PID of the last command run after sending to the background and then using fg to bring it back - and then we could potentially try to sigkill that:

> npm start & export REACTPID=$! ; fg
# in another terminal
> kill 9 ${REACTPID}

Not sure this is really going to work though, I do see the need for us to dive back into this problem.

SeedyROM · 2022-03-01T12:29:02Z

This is what I've been doing to kill the process:

> lsof -n -i :3000 | grep LISTEN
node    273716 USER   20u  IPv4 3315639      0t0  TCP *:hbci (LISTEN)
> kill 273716

lucasfernog · 2022-03-28T00:27:08Z

The issue was fixed on Windows, but the Svelte template still has issues on Linux/macOS, we could only fix it using SIGKILL which is not a good approach.

Janaka-Steph · 2022-03-28T11:14:57Z

The issue should stay open then

Janaka-Steph · 2022-03-31T06:36:38Z

If anyone interested, you can kill the previous process when launching the app like so:
"beforeDevCommand": "kill -9 $(lsof -i :3003 -t) &>/dev/null || true && yarn start"

Janaka-Steph · 2022-03-31T14:17:55Z

@FabianLars As discussed on Discord it appears that the issue still persist on MacOS M1, with create-react-app, quitting the app from red cross or Dock. Quitting with Ctrl+C on CLI kills the process successfully.
Here are the steps I took:

npx create-react-app my-app
cd my-app
cargo tauri init
cargo update -p tauri
# add `yarn start` as beforeDevCommand
cargo tauri dev
# quit app with red cross or from Dock
lsof -i -P -n | grep LISTEN 
# process still running

▶ cargo tauri info

Environment
  › OS: Mac OS 12.3.0 X64
  › Node.js: 16.14.2
  › npm: 8.1.4
  › pnpm: Not installed!
  › yarn: 1.22.17
  › rustup: 1.24.3
  › rustc: 1.59.0
  › cargo: 1.59.0
  › Rust toolchain: stable-aarch64-apple-darwin 

Packages
  › @tauri-apps/cli [NPM]: 1.0.0-rc.7
  › @tauri-apps/api [NPM]: Not installed!
  › tauri [RUST]: 1.0.0-rc.6,
  › tauri-build [RUST]: 1.0.0-rc.5,
  › tao [RUST]: 0.7.0,
  › wry [RUST]: 0.14.0,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../build
  › devPath: http://localhost:3000/
  › framework: React

App directory structure
  ├─ node_modules
  ├─ public
  ├─ src-tauri
  ├─ .git
  ├─ .idea
  └─ src

lucasfernog · 2022-04-01T01:17:22Z

Thanks for the steps to reproduce it, I'll give it a try soon.

NanoAi · 2023-01-13T23:15:03Z

This issue still happens for me on Vite, mirrored from the Discord.

To reproduce...

Create a Vite + Tauri app.
Run tauri dev (cargo tauri dev in my case.)
Close the app.
Observe that the console remains held by the "vite" process however the standard exit command doesn't work and a ctrl + c must be sent.

(I'll attach a text version when I can.)

chirag1992m · 2024-04-05T04:57:37Z

I have been running into the same issue. Is there a resolution to this?

Killing the app with ctrl + C is fine, but closing the app with the cross button runs into the error:

ELIFECYCLE  Command failed with exit code 4294967295

juji · 2024-07-16T18:35:47Z

npm i -D kill-port

./package.json

{
  "scripts":{
    "dev": "kill-port 5173; npx tauri dev; kill-port 5173",
    "dev:vite": "vite --port 5173 --mode ssr",
  }
}

./src-tauri/tauri.conf.json

{
  "build": {
    "beforeDevCommand": "npm run dev:vite",
    "devPath": "http://localhost:5173",
  }
}

harshkhandeparkar added the type: bug label Oct 23, 2021

amrbashir changed the title ~~[CTA] Closing App Doesn't Stop Devserver~~ beforeDevCommand is not killed on app exit Oct 23, 2021

amrbashir added scope: cli.rs The tauri-cli rust crate priority: 2 medium labels Oct 23, 2021

rondonjon mentioned this issue Oct 27, 2021

More devserver options #2813

Closed

lucasfernog added a commit that referenced this issue Nov 13, 2021

fix(cli.rs): terminate the beforeDevCommand, closes #2794

d08c5fd

amrbashir mentioned this issue Jan 27, 2022

[bug] Port does not close if window closed. #3292

Closed

amrbashir mentioned this issue Mar 1, 2022

[bug] react-scripts doesn't not terminate on shutdown or Crtl-C interrupt for npm run tauri dev #3577

Closed

oSethoum mentioned this issue Mar 4, 2022

Add tauri-react-template tauri-apps/awesome-tauri#37

Merged

27 tasks

Janaka-Steph mentioned this issue Mar 4, 2022

[Tauri] Tauri:dev doesn't close dev sever on quit tdex-network/tdex-dashboard#263

Closed

venashial mentioned this issue Mar 8, 2022

Fix GUI dev command (by not trying to kill the process) modrinth/code#22

Merged

lucasfernog closed this as completed in 94d78ef Mar 28, 2022

FabianLars reopened this Mar 31, 2022

lucasfernog added a commit that referenced this issue Apr 2, 2022

fix(cli): kill before dev command recursively on unix, closes #2794

67c06e1

lucasfernog mentioned this issue Apr 2, 2022

fix(cli): kill before dev command recursively on Unix, closes #2794 #3848

Merged

13 tasks

lucasfernog closed this as completed in e251e1b Apr 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`beforeDevCommand` is not killed on app exit #2794

`beforeDevCommand` is not killed on app exit #2794

harshkhandeparkar commented Oct 23, 2021

rondonjon commented Oct 27, 2021 •

edited

Loading

frnco commented Nov 13, 2021

lucasfernog commented Nov 13, 2021

SeedyROM commented Mar 1, 2022

Janaka-Steph commented Mar 1, 2022

nothingismagick commented Mar 1, 2022

FabianLars commented Mar 1, 2022

JonasKruckenberg commented Mar 1, 2022

nothingismagick commented Mar 1, 2022

SeedyROM commented Mar 1, 2022 •

edited

Loading

lucasfernog commented Mar 28, 2022

Janaka-Steph commented Mar 28, 2022

Janaka-Steph commented Mar 31, 2022

Janaka-Steph commented Mar 31, 2022

lucasfernog commented Apr 1, 2022

NanoAi commented Jan 13, 2023 •

edited

Loading

chirag1992m commented Apr 5, 2024

juji commented Jul 16, 2024 •

edited

Loading

beforeDevCommand is not killed on app exit #2794

beforeDevCommand is not killed on app exit #2794

Comments

harshkhandeparkar commented Oct 23, 2021

Describe the bug

To Reproduce

Expected behavior

rondonjon commented Oct 27, 2021 • edited Loading

frnco commented Nov 13, 2021

lucasfernog commented Nov 13, 2021

SeedyROM commented Mar 1, 2022

Janaka-Steph commented Mar 1, 2022

nothingismagick commented Mar 1, 2022

FabianLars commented Mar 1, 2022

JonasKruckenberg commented Mar 1, 2022

nothingismagick commented Mar 1, 2022

SeedyROM commented Mar 1, 2022 • edited Loading

lucasfernog commented Mar 28, 2022

Janaka-Steph commented Mar 28, 2022

Janaka-Steph commented Mar 31, 2022

Janaka-Steph commented Mar 31, 2022

lucasfernog commented Apr 1, 2022

NanoAi commented Jan 13, 2023 • edited Loading

chirag1992m commented Apr 5, 2024

juji commented Jul 16, 2024 • edited Loading

`beforeDevCommand` is not killed on app exit #2794

`beforeDevCommand` is not killed on app exit #2794

rondonjon commented Oct 27, 2021 •

edited

Loading

SeedyROM commented Mar 1, 2022 •

edited

Loading

NanoAi commented Jan 13, 2023 •

edited

Loading

juji commented Jul 16, 2024 •

edited

Loading