Skip to content

Ease plugin hook restrictions#3404

Merged
lucasfernog merged 8 commits into
devfrom
fix/plugin-dx
Feb 13, 2022
Merged

Ease plugin hook restrictions#3404
lucasfernog merged 8 commits into
devfrom
fix/plugin-dx

Conversation

@JonasKruckenberg
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Relaxes the Sync Requirement for plugin callbacks and allows FnMut callbacks as the setup hook.
Ideally we should make this FnOnce as the setup hook must only ever be called once anyway, but I haven't found a nice way to do so yet (Can one take a value out of a trait object? Can we call the fn and replace it's memory somehow?)

@JonasKruckenberg JonasKruckenberg requested a review from a team February 11, 2022 15:32
@JonasKruckenberg JonasKruckenberg changed the title Fix/plugin dx Ease plugin setup restrictiond Feb 11, 2022
@JonasKruckenberg JonasKruckenberg changed the title Ease plugin setup restrictiond Ease plugin setup restrictiond Feb 11, 2022
@JonasKruckenberg JonasKruckenberg changed the title Ease plugin setup restrictiond Ease plugin setup restrictions Feb 11, 2022
@JonasKruckenberg JonasKruckenberg changed the title Ease plugin setup restrictions Ease plugin hook restrictions Feb 11, 2022
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner February 11, 2022 16:41
lucasfernog
lucasfernog previously approved these changes Feb 12, 2022
@lucasfernog
Copy link
Copy Markdown
Member

@JonasKruckenberg can you fix fmt here

@JonasKruckenberg
Copy link
Copy Markdown
Member Author

done

@lucasfernog lucasfernog merged commit fd557e9 into dev Feb 13, 2022
@lucasfernog lucasfernog deleted the fix/plugin-dx branch February 13, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants