Ease plugin hook restrictions #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKruckenberg
changed the title
setup restrictiond
JonasKruckenberg
changed the title
setup restrictiondsetup restrictions
JonasKruckenberg
changed the title
setup restrictions
lucasfernog
previously approved these changes
Feb 12, 2022
|
@JonasKruckenberg can you fix fmt here |
|
done |
lucasfernog
approved these changes
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Relaxes the
SyncRequirement for plugin callbacks and allows FnMut callbacks as thesetuphook.Ideally we should make this
FnOnceas the setup hook must only ever be called once anyway, but I haven't found a nice way to do so yet (Can one take a value out of a trait object? Can we call the fn and replace it's memory somehow?)