Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api.js): appWindow shown as type any, fixes #3747 #3772

Merged
merged 3 commits into from
Mar 24, 2022
Merged

fix(api.js): appWindow shown as type any, fixes #3747 #3772

merged 3 commits into from
Mar 24, 2022

Conversation

FabianLars
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@FabianLars FabianLars requested a review from a team March 24, 2022 18:44
lucasfernog
lucasfernog previously approved these changes Mar 24, 2022
View reviewed changes
@FabianLars FabianLars requested a review from a team as a code owner March 24, 2022 18:55
@FabianLars
Copy link
Member Author

One day i will learn to add change files too 🤦

@lucasfernog lucasfernog merged commit 1deeb03 into dev Mar 24, 2022
@lucasfernog lucasfernog deleted the fix/appwindow-any-type branch March 24, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianLars @lucasfernog