-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new js apis #5136
Closed
Closed
feat: new js apis #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
29 tasks
29 tasks
amrbashir
force-pushed
the
new-js-apis
branch
from
September 6, 2022 17:29
fc91bd8
to
08e828d
Compare
amrbashir
force-pushed
the
new-js-apis
branch
from
September 6, 2022 17:41
08e828d
to
cf4b94a
Compare
amrbashir
force-pushed
the
new-js-apis
branch
from
September 6, 2022 18:46
a2682e5
to
1644b9c
Compare
amrbashir
force-pushed
the
new-js-apis
branch
3 times, most recently
from
September 6, 2022 19:29
7f9e024
to
70c69af
Compare
amrbashir
force-pushed
the
new-js-apis
branch
from
September 6, 2022 19:30
2987088
to
b3b251a
Compare
amrbashir
force-pushed
the
new-js-apis
branch
from
September 7, 2022 18:17
d660fa2
to
ad9df2c
Compare
amrbashir
force-pushed
the
new-js-apis
branch
from
September 8, 2022 19:22
6c09479
to
f5effcd
Compare
amrbashir
force-pushed
the
new-js-apis
branch
from
September 15, 2022 23:33
c293807
to
0af01e6
Compare
vdvman1
reviewed
Sep 15, 2022
amrbashir
force-pushed
the
new-js-apis
branch
from
September 18, 2022 02:58
03e29e7
to
02a2526
Compare
This was
linked to
issues
Sep 30, 2022
amrbashir
force-pushed
the
new-js-apis
branch
3 times, most recently
from
December 28, 2022 20:49
acdea0f
to
c33d47b
Compare
amrbashir
force-pushed
the
new-js-apis
branch
from
December 28, 2022 20:50
c33d47b
to
780f0ef
Compare
amrbashir
force-pushed
the
new-js-apis
branch
from
January 16, 2023 22:41
3552be2
to
d9df333
Compare
amrbashir
force-pushed
the
new-js-apis
branch
from
January 16, 2023 22:42
d9df333
to
bf8b366
Compare
Yesterday17
reviewed
Feb 8, 2023
Are |
@amrbashir we'll need to find some time to move these to the plugins-workspace repo. I would wait a little longer on the FS APIs, since we'll see if cap-std can help us there (see #6107). |
sure, I will start on porting them to plugins-workspace this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2233
closes #4490
closes #4350
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
Although some of the APIs intended in this PR could be add in a minor version of v1, The majority will be breaking changes so it is better to just include all in one PR for v2. I will also try to split the PR into a reviewable chunks.
TODOS:
os
moduletype()
platform()
to match Rust's implementation.hostname()
tempdir()
totempDir()
path
moduletempDir()
fs
modulecreate()
open()
close()
FsFile
classclose()
read()
write()
seek()
truncate()
stat()
write()
writeFile()
writeTextFile()
writeBinaryFile()
read()
readFile()
readTextFile()
readTextFileLines()
readBinaryFile()
copyFile()
readDir()
mkdir()
remove()
rename()
seek()
truncate()
ftruncate()
stat()
lstat()
fstat()
http
modulefetch
compatible with the web apifile://
onreqwest-client
featurefetch
usingAbortController
Client
andgetClient
window
moduleappWindow
WindowManager
,WebviewHandle
andWebViewWindow
into oneWindow
class.