Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): use AsyncMessageDialog for non Linux, closes #7182 #7200

Closed
wants to merge 2 commits into from

Conversation

pewsheen
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Issue #7182

This patch is trying to follow how FileDialog deals with the async dialog. Non-Linux systems will use the AsyncMessageDialog.

Tested in macOS, Windows, and Linux. Only macOS will center the dialog.

Although the issue requests to center the dialog on the window, I think someone might want to center the dialog on the screen.

@pewsheen pewsheen requested a review from a team as a code owner June 14, 2023 13:33
@wusyong wusyong added the status: needs review A maintainer must review this code label Jun 15, 2023
@pewsheen pewsheen changed the base branch from dev to next June 15, 2023 10:49
@pewsheen pewsheen changed the base branch from next to dev June 15, 2023 10:49
@pewsheen
Copy link
Contributor Author

Gonna merge to next branch.
I'll open another PR after I pick to https://github.com/tauri-apps/tauri-plugin-dialog

@pewsheen pewsheen closed this Jun 15, 2023
@pewsheen pewsheen deleted the async-message-dialog branch January 31, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review A maintainer must review this code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants