Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(updater/nsis): migrate run updater using powershell to ShellExecute #9818

Merged
merged 11 commits into from
May 22, 2024

Conversation

muwoo
Copy link

@muwoo muwoo commented May 19, 2024

@muwoo muwoo requested a review from a team as a code owner May 19, 2024 04:42
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution, this PR contains a number of breaking changes and we can't accept it as is.

core/tauri/Cargo.toml Outdated Show resolved Hide resolved
core/tauri/Cargo.toml Outdated Show resolved Hide resolved
core/tauri/src/updater/core.rs Show resolved Hide resolved
core/tauri/src/updater/core.rs Outdated Show resolved Hide resolved
core/tauri/src/updater/core.rs Outdated Show resolved Hide resolved
@muwoo
Copy link
Author

muwoo commented May 21, 2024

@amrbashir Thank you for pointing out the problems. These problems have been fixed. Please check again.

  • cargo test passed
  • cargo clippy passed

core/tauri/src/updater/core.rs Outdated Show resolved Hide resolved
core/tauri/src/updater/core.rs Outdated Show resolved Hide resolved
core/tauri/src/updater/core.rs Outdated Show resolved Hide resolved
core/tauri/src/updater/core.rs Outdated Show resolved Hide resolved
@amrbashir
Copy link
Member

Can you also add a change file in .changes directory? thanks

@muwoo
Copy link
Author

muwoo commented May 22, 2024

@amrbashir Thank you very much for your guidance. I am a newbie to Tauri. I just started reading the source code of Tauri. I did not understand some logic deeply enough, so I made some mistakes. It is a great honor to participate in Tauri's code contributions and receive your guidance. This taught me a lot!

@Legend-Master
Copy link
Contributor

We can use HSTRING here as we're using windows crate instead of windows-sys crate (we're still on windows 0.39 so we need to convert some types manually 😢)

@muwoo
Copy link
Author

muwoo commented May 22, 2024

We can use HSTRING here as we're using windows crate instead of windows-sys crate (we're still on windows 0.39 so we need to convert some types manually 😢)

Thank you for your modification suggestions!

amrbashir
amrbashir previously approved these changes May 22, 2024
@amrbashir
Copy link
Member

@amrbashir Thank you very much for your guidance. I am a newbie to Tauri. I just started reading the source code of Tauri. I did not understand some logic deeply enough, so I made some mistakes. It is a great honor to participate in Tauri's code contributions and receive your guidance. This taught me a lot!

Thanks for you contribution. It is an honor for us as well and if you ever need help with the codebase just get in touch with us on Discord.

@amrbashir amrbashir changed the title refactor(updater): migrate run updater using powershell to ShellExecute refactor(updater/nsis): migrate run updater using powershell to ShellExecute May 22, 2024
@amrbashir amrbashir merged commit 50aabad into tauri-apps:1.x May 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants