-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(updater/nsis): migrate run updater using powershell to ShellExecute #9818
Conversation
muwoo
commented
May 19, 2024
•
edited by amrbashir
Loading
edited by amrbashir
- Fix flashing powershell window on update
- Closes autoUpdater error: Running NSIS installer from powershell has failed to start[bug] #9737
- discussions in Can we set the directory for downloaded update files when configuring the tauri updater? #9747
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution, this PR contains a number of breaking changes and we can't accept it as is.
@amrbashir Thank you for pointing out the problems. These problems have been fixed. Please check again.
|
Can you also add a change file in |
@amrbashir Thank you very much for your guidance. I am a newbie to Tauri. I just started reading the source code of Tauri. I did not understand some logic deeply enough, so I made some mistakes. It is a great honor to participate in Tauri's code contributions and receive your guidance. This taught me a lot! |
We can use |
Thank you for your modification suggestions! |
Thanks for you contribution. It is an honor for us as well and if you ever need help with the codebase just get in touch with us on Discord. |