refactor(ipc): use http::Request on with_ipc_handler #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Mar 6, 2024
src/lib.rs
Outdated
| @@ -1025,6 +1025,26 @@ impl<'a> WebViewBuilder<'a> { | |||
| } | |||
| } | |||
|
|
|||
| /// Request from a IPC message. See [`WebViewBuilder::with_ipc_handler`] for more information. | |||
| pub struct IpcRequest { | |||
There was a problem hiding this comment.
instead of a new type, can't we just pass the url as a second argument with Option<String>?
There was a problem hiding this comment.
maybe we should use http::Request instead? we might add new parameters to this closure in the future (like a closure to provide a response to the webview) and it's more type safe to have a dedicated type for multiple parameters
lucasfernog
changed the title
amrbashir
reviewed
Mar 6, 2024
amrbashir
previously approved these changes
Mar 6, 2024
|
@amrbashir sorry had to push a docs update :D |
amrbashir
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the ipc_handler closure to get a new IpcRequest type instead of only receive the message string.
On macOS, iOS and Windows, we can read the request URL which enhances the security checks to verify the request source (currently only the url() function can be used, which does not work on contexts where an iframe is used).
For custom protocols, I believe the Origin header can be used instead of this.