Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split matlab tests in their own files and share them across tests. #31

Merged
merged 4 commits into from
Apr 1, 2016

Conversation

papadop
Copy link
Contributor

@papadop papadop commented Mar 27, 2016

This is the next step in test reorganisation. Matlab file are put in separate files and shared across the various tests. This also corrected a few tests that were blocking (error in the matlab file) at least on linux (mainly write_char tests). All tests now pass.

Note that I probably broke matlab tests previously by removing the newline in the PASSED chracter chain in the result. I think the testing framework is a little fragile here (due to the horrible syntax where [] are string delimiter), but I did not find any other way of doing things.

Quite a few matlab test files are parameterized by a type, to commonize tests differing by just a type.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.346% when pulling 4ecd6bc on papadop:NewTestsReorg into ac0565c on tbeu:master.

@tbeu
Copy link
Owner

tbeu commented Mar 29, 2016

Can you please attach the testsuite.log to this ticket. Thanks.

@papadop
Copy link
Contributor Author

papadop commented Mar 29, 2016

File renamed testsuite.txt, otherwise github will not accept it.... But here it is....
testsuite.txt

@papadop
Copy link
Contributor Author

papadop commented Mar 30, 2016

New testsuite.log after last change (no matlab tests in that one).
testsuite.txt

@papadop
Copy link
Contributor Author

papadop commented Mar 30, 2016

With the last commit, I believe that now all tests results are split out of the .at files.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 71.262% when pulling 5e21621 on papadop:NewTestsReorg into ac0565c on tbeu:master.

@tbeu
Copy link
Owner

tbeu commented Mar 30, 2016

Do you also have the testsuite.log with MATLAB tests run?

@papadop
Copy link
Contributor Author

papadop commented Mar 30, 2016

Well, I have not touched to matlab stuff with the last patches, so the previous testsuite.log should remains relevant here. But I will do that once at work.

@papadop
Copy link
Contributor Author

papadop commented Apr 1, 2016

OK this work is now really finished (there were some more tests). There are some discrepancies between mat5 and mat73 tests results, but that will be dealt with in another branch. Overall, the testing framework is now 48.1% of what it was in size, and in my opinion it is now easier to find differences with the various matlab file formats. In a few minutes, I will post the full testsuite.log file (just waiting for it to finish on a clean tree).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 71.262% when pulling 0a59bcc on papadop:NewTestsReorg into ac0565c on tbeu:master.

@tbeu
Copy link
Owner

tbeu commented Apr 1, 2016

Thanks. By coincidence I am just working on the merge right now...

@papadop
Copy link
Contributor Author

papadop commented Apr 1, 2016

And the testsuite.log is:
testsuite.txt

@tbeu
Copy link
Owner

tbeu commented Apr 1, 2016

Nice to see them all succeeding. And takes less than 20min.

@tbeu tbeu merged commit 0a59bcc into tbeu:master Apr 1, 2016
tbeu added a commit that referenced this pull request Apr 12, 2018
tbeu added a commit that referenced this pull request Apr 13, 2018
MaartenBent pushed a commit to MaartenBent/matio that referenced this pull request Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants