document/fix(?) parsing of 1e-/*test*/-5 which reproduces incorrectly

very much related to cockroachdb#1810.
tbg · Jul 25, 2015 · a21f02c · a21f02c
1 parent 0b4ea4d
commit a21f02c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/sql/parser/expr.go b/sql/parser/expr.go
@@ -213,7 +213,11 @@ func (node IntVal) String() string {
 type NumVal string
 
 func (node NumVal) String() string {
-	return string(node)
+	s := string(node)
+	if l := len(s); l > 0 && s[l-1] == '-' {
+		s += " "
+	}
+	return s
 }
 
 // BoolVal represents a boolean.

diff --git a/sql/parser/parse_test.go b/sql/parser/parse_test.go
@@ -274,6 +274,8 @@ func TestParse2(t *testing.T) {
 			`SELECT *, - -5`},
 		{"SELECT -\n-5",
 			`SELECT - -5`},
+		{"SELECT 1e-\n-1",
+			`SELECT 1e- -1`},
 	}
 	for _, d := range testData {
 		stmts, err := Parse(d.sql)