Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #19: remove line terminator normalisation #22

Merged
merged 1 commit into from Jan 9, 2017

Conversation

Projects
None yet
1 participant
@michaelficarra
Copy link
Member

commented Jan 9, 2017

Fixes #19. Implementors have made it clear that they do not plan to implement Function.prototype.toString line terminator normalisation due to either performance costs or extreme difficulty in preserving performance. Line terminator normalisation is a feature of Function.prototype.toString that never existed in reality. It was added mostly for consistency with templates and to avoid accidentally observing file encodings. But we are not trying to design a nice API. We are trying to document a legacy feature of JavaScript that would be more appropriate in Annex B. Because of this, we will make it easy for implementors to follow the spec with as few changes to their implementation as possible. The goal of this proposal is to simply further specify the Function.prototype.toString behaviour and align implementations where they deviate from each other.

@michaelficarra michaelficarra merged commit 09e0a9e into master Jan 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@michaelficarra michaelficarra deleted the remove-line-terminator-normalisation branch Jan 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.