This repository was archived by the owner on Jan 25, 2022. It is now read-only.
make HostHasSourceTextAvailable idempotent and never abrupt #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Mar 5, 2018
proposal.html
Outdated
| <emu-alg> | ||
| 1. If _func_ is a <emu-xref href="#sec-bound-function-exotic-objects">Bound Function exotic object</emu-xref> or a <emu-xref href="#sec-ecmascript-standard-built-in-objects">built-in Function object</emu-xref>, then return an implementation-dependent String source code representation of _func_. The representation must have the syntax of a |NativeFunction|. Additionally, if _func_ is a <emu-xref href="#sec-well-known-intrinsic-objects">Well-known Intrinsic Object</emu-xref>, the portion of the returned String that would be matched by |IdentifierName| must be the initial value of the *name* property of _func_. | ||
| 1. If _func_ has a [[SourceText]] internal slot and Type(_func_.[[SourceText]]) is String and ? HostHasSourceTextAvailable(_func_), then return _func_.[[SourceText]]. | ||
| 1. If _func_ has a [[SourceText]] internal slot and Type(_func_.[[SourceText]]) is String and HostHasSourceTextAvailable(_func_) is *true*, then return _func_.[[SourceText]]. |
There was a problem hiding this comment.
should this have a ! since it won't ever be abrupt?
There was a problem hiding this comment.
Hah, this comes back to the issue @jmdyck raised--it depends whether you believe all abstract operations return a completion record!
There was a problem hiding this comment.
Well this one certainly does.
There was a problem hiding this comment.
it depends whether you believe all abstract operations return a completion record!
(It's actually orthogonal to that.)
There was a problem hiding this comment.
Well, HostHasSourceTextAvailable returns a completion record, I agree with @ljharb that a ! would be good.
littledan
approved these changes
Mar 5, 2018
michaelficarra
force-pushed
the
stricter-hosthassourcetextavailable
branch
from
05034fe to
94c03a8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses @anba's comments in #26 (comment).
Fixes #27.
/cc @domenic @phoddie for review