Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upobj.[[Get]](j) in Array.prototype.sort section lacks the 2nd argument #1180
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
What about replacing it with |
ljharb
added
question
editorial change
labels
Apr 22, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Sounds good to me. |
ljharb
added
spec bug
good first patch
and removed
question
labels
Apr 23, 2018
added a commit
to mysticatea/ecma262
that referenced
this issue
Apr 23, 2018
mysticatea
referenced a pull request that will
close
this issue
Apr 23, 2018
Open
Editorial: replace obj.[[Get]](j) with Get(obj, j) #1183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mysticatea commentedApr 22, 2018
In https://tc39.github.io/ecma262/#sec-array.prototype.sort section, the following sentence exists:
Now,
obj.[[Get]](j)in the sentence doesn't have the 2nd argumentreceiver, so I guess thatthisin accessor properties areundefinedin sorting. For example:However, those
thiss are notundefinedin real world.I'm suspecting that we should fix those
obj.[[Get]](j)toobj.[[Get]](j, obj).