[Normative] Add RegExp dotAll mode (s flag)
#1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Nov 11, 2017
ljharb
added
the
pending stage 4
littledan
approved these changes
Nov 16, 2017
spec.html
Outdated
| @@ -30862,6 +30869,21 @@ | |||
| </emu-note> | |||
| </emu-clause> | |||
|
|
|||
| <emu-clause id="sec-get-regexp.prototype.dotAll"> | |||
| <h1>get RegExp.prototype.dotAll</h1> | |||
There was a problem hiding this comment.
Nit: The rest of the methods are arranged in alphabetical order. If you want to continue that with this patch, this could go a little higher in the file.
mathiasbynens
force-pushed
the
dotall
branch
from
d7dc4a5 to
6455fe5
Compare
|
This PR looks good, thank you! |
|
Just to confirm, tests are in test262? |
|
@bterlson Yep, see tc39/test262#1009 . |
|
All the Stage 4 criteria + links to how they are resolved for this proposal are here: tc39/proposal-regexp-dotall-flag#4 |
ljharb
added
has test262 tests
and removed
pending stage 4
claudepache
approved these changes
Dec 13, 2017
ljharb
approved these changes
Dec 13, 2017
|
Grats @mathiasbynens and everyone that contributed to this proposal :-D |
mathiasbynens
added a commit
to tc39/proposal-regexp-dotall-flag
that referenced
this pull request
Dec 18, 2017
tc39/ecma262#1028 has been merged as tc39/ecma262@d978ed1. Closes #4.
mathiasbynens
added a commit
to tc39/proposal-regexp-dotall-flag
that referenced
this pull request
Dec 19, 2017
tc39/ecma262#1028 has been merged as tc39/ecma262@d978ed1. Closes #4.
mathiasbynens
added a commit
to tc39/proposal-regexp-dotall-flag
that referenced
this pull request
Dec 19, 2017
tc39/ecma262#1028 has been merged as tc39/ecma262@d978ed1. Closes #4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal repo: https://github.com/tc39/proposal-regexp-dotall-flag