Normative: Prevent JSON.stringify from returning ill-formed Unicode strings #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
ljharb
previously requested changes
Jan 8, 2019
There was a problem hiding this comment.
Would you mind updating the commit to match our conventions? Specifically, start it with "Normative: "
gibson042
force-pushed
the
proposal-well-formed-stringify
branch
from
dcf7eb1
to
2004447
Compare
gibson042
changed the title
|
Done. |
bterlson
approved these changes
Jan 25, 2019
ljharb
added
has stage 4
zenparsing
approved these changes
Feb 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements https://github.com/tc39/proposal-well-formed-stringify , currently at stage 3. Tests have already been merged.
Fixes #944