Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Adding Intl.DateTimeFormat formatRange/formatRangeToParts specification #532

Merged
merged 5 commits into from
Feb 18, 2021
Merged

Normative: Adding Intl.DateTimeFormat formatRange/formatRangeToParts specification #532

merged 5 commits into from
Feb 18, 2021

Conversation

fabalbon
Copy link
Member

@fabalbon fabalbon commented Jan 15, 2021 •
edited
Loading

@fabalbon fabalbon marked this pull request as ready for review January 20, 2021 20:38
@jridgewell jridgewell mentioned this pull request Jan 26, 2021
Open
ryzokuken
ryzokuken requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When rebasing Temporal on top of this proposal, we uncovered a few lint errors. Please fix them (and all others that come up from ecmarkup, Temporal only uses a subset of the spec).

spec/datetimeformat.html Outdated Show resolved Hide resolved
spec/datetimeformat.html Outdated Show resolved Hide resolved
spec/datetimeformat.html Outdated Show resolved Hide resolved
spec/datetimeformat.html Outdated Show resolved Hide resolved
spec/datetimeformat.html Outdated Show resolved Hide resolved
spec/datetimeformat.html Outdated Show resolved Hide resolved
@fabalbon fabalbon added stage 4 and removed stage 3 labels Feb 3, 2021
@sffc sffc added has consensus Has consensus from TC39-TG2 has consensus (TG1) Has consensus from TC39-TG1 labels Feb 11, 2021
Ms2ger
Ms2ger reviewed Feb 15, 2021
View reviewed changes
spec/datetimeformat.html Outdated Show resolved Hide resolved
spec/datetimeformat.html Outdated Show resolved Hide resolved
@ryzokuken ryzokuken mentioned this pull request Feb 15, 2021
Merged
ryzokuken
ryzokuken approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @Ms2ger's suggestions applied.

leobalter and others added 2 commits February 17, 2021 17:11
@leobalter @Ms2ger
Update spec/datetimeformat.html
457cc00 
Co-authored-by: Ms2ger <Ms2ger@gmail.com>
@leobalter @Ms2ger
Update spec/datetimeformat.html
8d48e28 
Co-authored-by: Ms2ger <Ms2ger@gmail.com>
leobalter
leobalter approved these changes Feb 18, 2021
View reviewed changes
spec/datetimeformat.html Outdated Show resolved Hide resolved
@leobalter
Copy link
Member

LGTM

We have a few conflicts in the CI but I'm planning to address them after merging.

@leobalter leobalter merged commit be13e76 into tc39:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger left review comments

@leobalter leobalter leobalter approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

Assignees
No one assigned
Labels
has consensus (TG1) Has consensus from TC39-TG1 has consensus Has consensus from TC39-TG2 has tests stage 4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IntervalFormat
5 participants
@fabalbon @leobalter @Ms2ger @ryzokuken @sffc