Layering: Host hook to initialize new Realms #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of addressing tc39#225 In HTML, this host hook would probably do something related to [setting up a window environment settings object](https://html.spec.whatwg.org/#set-up-a-window-environment-settings-object). I wouldn't propose that this would add properties to the global object in HTML. This PR makes a new host hook section, as another hook may be needed for new modules (in the context of tc39#224)
caridy
approved these changes
Feb 28, 2020
|
If the intention is not to mutate the global object, could the spec state that somehow? |
caridy
reviewed
Feb 28, 2020
| @@ -74,6 +74,7 @@ location: https://rawgit.com/tc39/proposal-realms/master/index.html | |||
| 1. Set _O_.[[Realm]] to _realmRec_. | |||
| 1. Perform ? SetRealmGlobalObject(_realmRec_, *undefined*, *undefined*). | |||
| 1. Perform ? SetDefaultGlobalBindings(_O_.[[Realm]]). | |||
| 1. Perform ? HostInitializeUserRealm(_O_.[[Realm]]). | |||
There was a problem hiding this comment.
In InitializeHostDefinedRealm, we do:
Create any implementation-defined global object properties on globalObj.
I wonder if that's something that we should do here as part of HostInitializeUserRealm, or doing it here.
erights
approved these changes
Feb 28, 2020
caridy
approved these changes
Feb 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of addressing #225
In HTML, this host hook would probably do something related to setting up a window environment settings object. I wouldn't propose that this would add properties to the global object in HTML.
This PR makes a new host hook section, as another hook may be needed for new modules (in the context of #224)