-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy options object for PlainYearMonth.{add,subtract} and InterpretTemporalDateTimeFields #1748
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1748 +/- ##
==========================================
+ Coverage 94.79% 94.96% +0.17%
==========================================
Files 19 19
Lines 10963 10962 -1
Branches 1713 1740 +27
==========================================
+ Hits 10392 10410 +18
+ Misses 556 537 -19
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Marking the normative PR as draft to avoid accidental merging |
This change achieved consensus in TC39. Can be merged when the wording issues are addressed and the tests are added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment on the tests.
polyfill/test/PlainYearMonth/prototype/add/calendar-arguments.js
Outdated
Show resolved
Hide resolved
53f8a49
to
0b44710
Compare
d9e9fce
to
9491256
Compare
…mporalDateTimeFields to prevent user-modified objects from interfering with later operations. Fixes #1686
9491256
to
e9fe915
Compare
… to prevent user-modified objects from interfering with later operations.
Fixes #1686