Normative: Fix fractionalSecondDigits behaviour in Duration.toString() #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
added
spec-text
|
Draft until presented at TC39. cc @rkirsling |
Codecov Report
@@ Coverage Diff @@
## main #1956 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 19 19
Lines 10967 10967
Branches 1743 1743
=======================================
Hits 10415 10415
Misses 535 535
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ptomato
force-pushed
the
1763-duration-fractionalseconddigits
branch
from
0cf44aa
to
1690ed4
Compare
Ms2ger
approved these changes
Dec 6, 2021
|
This achieved consensus at the December 2021 TC39 meeting. |
Previously, code that combined zero subsecond units with a specified
precision, such as the following:
Temporal.Duration.from({ years: 3 }).toString({ fractionalSecondDigits: 5 })
would not render the seconds with the correct precision. The above example
would return 'P3Y' and not 'P3YT0.00000S'.
Closes: #1763
ptomato
force-pushed
the
1763-duration-fractionalseconddigits
branch
from
1690ed4
to
228f183
Compare
justingrant
added a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Dec 20, 2021
justingrant
added a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Jan 8, 2022
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 4, 2022
tc39/proposal-temporal#1956 clarified that the fractionalSecondDigits and smallestUnit options to Temporal.Duration.p.toString() specified the exact number of digits after the decimal point, no more and no less. This was a normative change that achieved consensus at the December 2021 TC39 meeting.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 4, 2022
tc39/proposal-temporal#1956 clarified that the fractionalSecondDigits and smallestUnit options to Temporal.Duration.p.toString() specified the exact number of digits after the decimal point, no more and no less. This was a normative change that achieved consensus at the December 2021 TC39 meeting.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 5, 2022
tc39/proposal-temporal#1956 clarified that the fractionalSecondDigits and smallestUnit options to Temporal.Duration.p.toString() specified the exact number of digits after the decimal point, no more and no less. This was a normative change that achieved consensus at the December 2021 TC39 meeting.
rwaldron
pushed a commit
to tc39/test262
that referenced
this pull request
Feb 8, 2022
tc39/proposal-temporal#1956 clarified that the fractionalSecondDigits and smallestUnit options to Temporal.Duration.p.toString() specified the exact number of digits after the decimal point, no more and no less. This was a normative change that achieved consensus at the December 2021 TC39 meeting.
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
May 7, 2022
https://bugs.webkit.org/show_bug.cgi?id=240193 Reviewed by Yusuke Suzuki. This patch implements the spec correction of tc39/proposal-temporal#1956: `new Temporal.Duration.from(1).toString({ fractionalSecondDigits: 2 })` should be P1Y0.00S, not just P1Y. * stress/temporal-duration.js: Add a test case. * test262/expectations.yaml: Mark two test cases as passing. * runtime/TemporalDuration.cpp: (JSC::TemporalDuration::toString): Canonical link: https://commits.webkit.org/250388@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, code that combined zero subsecond units with a specified
precision, such as the following:
Temporal.Duration.from({ years: 3 }).toString({ fractionalSecondDigits: 5 })
would not render the seconds with the correct precision. The above example
would return 'P3Y' and not 'P3YT0.00000S'.
Closes: #1763