Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test string whitespace coercion for BigInt values #1354

Open
leobalter opened this issue Nov 21, 2017 · 1 comment
Open

Test string whitespace coercion for BigInt values #1354

leobalter opened this issue Nov 21, 2017 · 1 comment

Comments

@leobalter
Copy link
Member

follow up for #1349

Some related files:

  • test/built-ins/BigInt/constructor-empty-string.js
  • test/built-ins/BigInt/constructor-trailing-leading-spaces.js
@leobalter leobalter mentioned this issue Nov 21, 2017
Merged
linusg added a commit to SerenityOS/serenity that referenced this issue Aug 30, 2022
@linusg
LibJS: Trim non-ASCII whitespace as well in StringToBigInt
15e3a99 
This was never caught since the original implementation AFAICT, and
isn't being covered by test262 either:
tc39/test262#1354
@linusg
Copy link
Member

linusg commented Aug 30, 2022

Five years later I've just fixed a bug in our engine that would've been caught by these tests, maybe someone still wants to add them for future implementors :^)

demostanis pushed a commit to demostanis/serenity that referenced this issue Sep 3, 2022
@linusg @demostanis
LibJS: Trim non-ASCII whitespace as well in StringToBigInt
370e39d 
This was never caught since the original implementation AFAICT, and
isn't being covered by test262 either:
tc39/test262#1354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leobalter @linusg