Class flags #20
Merged
Class flags #20
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 7b77e22 on classFlags into ** on master**. |
|
Travis errors can be ignored: all are due to now unsupported interpreters (I'll commit a fix). |
|
Changes Unknown when pulling 9f51d88 on classFlags into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that when a class has sever super-classes (ImmutableListMultimap in my specific example) and one of those has the SC_WRITE_METHOD flag set, it does not get folded together so that custom object data gets read. OR-ing the flags together for all super-classes seems to address.
I've also changed the java byte-array unit test to test the output as a tuple of ints rather than a python bytestring.
Tested mostly under python 2.7, all UTs pass (though there's still a warning about 5 unused bytes coming from one of the tests.)
Updated Author attributions as well.