Verbose tests for clang builds, to understand the crash in focus.test #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NULL pointer. This may be the cause for the crash.
…n these tests and focus.test
…tain _pause calls by controlPointerWarpTiming
… files, and slows down the tests a lot).
…, only run some test files.
…ashing pathname of it
… the test suite thinks of the candidate fix
andreas-kupries
pushed a commit
that referenced
this pull request
Jan 1, 2022
…is in PR#9 at GitHub: [#9]
andreas-kupries
pushed a commit
that referenced
this pull request
Jan 17, 2022
…plevel. This fix is entirely in tkInt.h (and is tested in event.test). This fix revealed a latent crash in the test suite (focus.test) with macOS, fix that also in tkFocus.c (see details in the discussion in ticket [b1d115fa60] and in successive commits in PR#9 at GitHub: #9). Finally, remove dead code from filebox.test (we were there when analyzing the previously mentioned crash in focus.test).
andreas-kupries
pushed a commit
that referenced
this pull request
Jan 17, 2022
…plevel. This fix is entirely in tkInt.h (and is tested in event.test). This fix revealed a latent crash in the test suite (focus.test) with macOS, fix that also in tkFocus.c (see details in the discussion in ticket [b1d115fa60] and in successive commits in PR#9 at GitHub: #9). Finally, remove dead code from filebox.test (we were there when analyzing the previously mentioned crash in focus.test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Note
Please do not file pull requests with Tk on Github. They are unlikely to be noticed in a timely fashion. Tk issues (including patches) are hosted in the tk fossil repository on core.tcl-lang.org; please post them there.