Convert Eithers into Results. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcr
approved these changes
Jul 9, 2017
| Right((v, _)) => Right(v) | ||
| } | ||
| pub fn execParser_<a: 'static>(parser: P<a>, input: InputStream, pos: Position) -> Result<a, ParseError> { | ||
| execParser(parser, input, pos, builtinTypeNames(), newNameSupply()).map(|(v, _)| v) |
| @@ -31,13 +31,15 @@ | |||
| #![feature(proc_macro)] | |||
| #![feature(slice_patterns, box_syntax, box_patterns, fnbox)] | |||
| #![allow(unused_parens)] | |||
| // Cut down on number of warnings until we manage it. | |||
| #![allow(non_snake_case, non_camel_case_types, unused_imports, unused_variables, dead_code)] | |||
|
👏👏👏 Looks straightforward to me. I agree about using the |
|
Thanks! I'll merge this as-is for now, since the other PR depends on it, and make the remaining Either change after that one. BTW, do you prefer merge or rebase? |
|
@birkenfeld Rebase :) But until we get to a viable alpha release, I'm not a stickler for either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have only done this where the Left variant was an obvious error
indication. There are a few Eithers left that can either stay
(use the either crate in that case?) or be replaced by domain-specific
enums.
Changes in
analysisare unchecked, see #9.Fixes #3