Start porting the Haskell test suite #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
force-pushed
the
testsuite
branch
from
84051ae
to
b701853
Compare
* Fixup formatting of lexer and parser error messages * Implement Display of tokens properly * Fix position tracking; errors now always point at the right token (or position where a token was expected) * Implement std::error::Error
* Fixup octal literal printing (Rust uses 0o123) * Use u128 type for C literals (to at least catch __int128) (Haskell uses its arbitrary-size type here, which is probably overkill) * Fix parsing of hex/octal string escapes
* Traverse: apply a function to all nodes (using the Any trait to avoid having to write a whole visitor, or multiple functions) * Equiv: check for AST equivalence (i.e. PartialEq, but ignore position info)
This is in preparation for later adding dynamic tests which need to generate tests using a build script, which is better in its own crate.
birkenfeld
force-pushed
the
testsuite
branch
from
a1cd6af
to
6e42f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (based on the
prettybranch) moves the test suite to its own crate, within a Cargo workspace.The first test I ported is the largest one, which parses, pretty-prints and reparses several thousand files from the GCC test suite. (They are in a tarball in the repo which is unpacked by the new
test.shscript.)In the process, I fixed some outstanding bugs, so now all of those files are parseable and after pretty-printing, parsing that results in the same AST.