New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed quoting issues #4

Closed
wants to merge 13 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@joodie
Contributor

joodie commented Oct 21, 2011

This patch simplifies the handling of string arguments and should fix all the string-quoting issues.

@tcrayford

This comment has been minimized.

Owner

tcrayford commented Oct 21, 2011

Do the tests still pass? I don't have a running clojure env anymore (and as you can see by the last commit date, I don't really work on this project anymore).

If you're interested, you could be a new maintainer.

@joodie

This comment has been minimized.

Contributor

joodie commented Oct 21, 2011

On Oct 21, 2011, at 1:30 PM, Tom Crayford wrote:

Do the tests still pass? I don't have a running clojure env anymore (and as you can see by the last commit date, I don't really work on this project anymore)

I'm not sure how much of the tests actually touch on the elisp code (since that's all I changed) but I cannot get the tests to run at all using lein test.

I get a Exception in thread "main" java.lang.ClassNotFoundException: difftest.core (NO_SOURCE_FILE:1)

And cake test gives me other errors (see below):

If you're interested, you could be a new maintainer.

I'm interested. Even in the current state its the only reasonable attempt at a refactoring toolkit for clojure and it's a shame if it gets no more work.

Joost.

cake test
error evaluating:
((with-context :test (run-project-tests namespaces opts)))
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.ClassNotFoundException: clojure.contrib.def (zip.clj:1)
at clojure.lang.LazySeq.sval (LazySeq.java:47)
clojure.lang.LazySeq.seq (LazySeq.java:56)
clojure.lang.RT.seq (RT.java:450)
clojure.core$seq.invoke (core.clj:122)
clojure.core$dorun.invoke (core.clj:2450)
clojure.core$doall.invoke (core.clj:2465)
cake.task$run_actions.invoke (task.clj:153)
cake.task$run_task$fn__685.invoke (task.clj:185)
cake.task$run_task.invoke (task.clj:182)
cake.task$run_task.invoke (task.clj:175)
cake.main$process_command.invoke (main.clj:25)
cake.server$create$fn__3322.invoke (server.clj:70)
cake.utils.server_socket$accept_fn$fn__3059$fn__3062.invoke (server_socket.clj:39)
cake.utils.server_socket$accept_fn$fn__3059.invoke (server_socket.clj:38)
clojure.lang.AFn.run (AFn.java:24)
java.lang.Thread.run (Thread.java:680)
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.ClassNotFoundException: clojure.contrib.def (zip.clj:1)
at clojure.lang.LazySeq.sval (LazySeq.java:47)
clojure.lang.LazySeq.seq (LazySeq.java:56)
clojure.lang.RT.seq (RT.java:450)
clojure.lang.RT.countFrom (RT.java:499)
clojure.lang.RT.count (RT.java:492)
bake.test$run_project_tests.invoke (test.clj:65)

@tcrayford

This comment has been minimized.

Owner

tcrayford commented Oct 21, 2011

That's almost definitely to do with clojure 1.2 splitting up clojure contrib (this was built on a pre-release version of clojure 1.2).

If you want to become a maintainer feel free to fork it, and let me know. I'll put a notice on here that this version is depreceated and people should see yours.

@joodie

This comment has been minimized.

Contributor

joodie commented Oct 21, 2011

On Oct 21, 2011, at 2:47 PM, Tom Crayford wrote:

That's almost definitely to do with clojure 1.2 splitting up clojure contrib (this was built on a pre-release version of clojure 1.2).

Makes sense.

If you want to become a maintainer feel free to fork it, and let me know. I'll put a notice on here that this version is depreceated and people should see yours.

I'll take a shot at getting the tests running and generally cleaning up stuff and if that works I'll let you know and you can publish the notification.

Also: I notice the .el file is under the GPL but none of the other files have any kind of copyright/licensing statement. Is the rest of the code under the EPL or something else?

Cheers,
Joost.

@tcrayford

This comment has been minimized.

Owner

tcrayford commented Oct 21, 2011

I should really move it all to BSD. I don't really have any worries about the licensing of this project (the .el file being under the gpl was just because I copied it from another elisp file)

@joodie

This comment has been minimized.

Contributor

joodie commented Oct 21, 2011

If you could put the changes to the license in your repo I can pull them in and go from there.

I made the tests work again under leiningen, by the way; just a question of removing the dev-dependencies.

Currently I'm looking at porting the parser to a supported version of parsley, but that's a little trickier than I expected.

Cheers,
Joost.

On Oct 21, 2011, at 6:36 PM, Tom Crayford wrote:

I should really move it all to BSD. I don't really have any worries about the licensing of this project (the .el file being under the gpl was just because I copied it from another elisp file)

Reply to this email directly or view it on GitHub:
#4 (comment)

@tcrayford

This comment has been minimized.

Owner

tcrayford commented Oct 21, 2011

Awesome. I'm working now, but I'll probably get to it tomorrow or sometime later tonight (EU timezone)

@joodie

This comment has been minimized.

Contributor

joodie commented Oct 21, 2011

Great!

I'll be out the rest of the day (also in the EU), but I'll take a look at it tomorrow.

By the way, it looks like I'm getting the hang of parsley :)

Talk to you later.
Joost.

On Oct 21, 2011, at 7:41 PM, Tom Crayford wrote:

Awesome. I'm working now, but I'll probably get to it tomorrow or sometime later tonight (EU timezone)

Reply to this email directly or view it on GitHub:
#4 (comment)

@joodie

This comment has been minimized.

Contributor

joodie commented Oct 24, 2011

Hi Tom,

Sorry to bother you again, but I would like to push out a new version of clojure-refactoring with my fixes and update to the latest parsley version and I want to have the licensing cleared up before I do that and "officially" take over as the maintainer.

If you have the time, can you please update the licensing information in your repo so I can pull it in and bake a new release?

Alternatively, just let me know what you want license-wise and I can make the changes myself. In any case, I do need your input on this before I proceed.

Thanks,
Joost.

@tcrayford

This comment has been minimized.

Owner

tcrayford commented Oct 24, 2011

Send me a pull request with it all changed to BSD (both the elisp and the clojure). Also put depreciation notices in the readme. I'll accept that, and you can start working.

Sorry I didn't get round to this.

tcrayford added a commit that referenced this pull request Oct 24, 2011

Merge pull request #5 from joodie/licensing
Licensing update as discussed in issue #4

@tcrayford tcrayford closed this Oct 24, 2011

@joodie

This comment has been minimized.

Contributor

joodie commented Oct 24, 2011

Thanks for resolving this so quickly.

Joost.

On Oct 24, 2011, at 8:31 PM, Tom Crayford wrote:

Send me a pull request with it all changed to BSD (both the elisp and the clojure). Also put depreciation notices in the readme. I'll accept that, and you can start working.

Sorry I didn't get round to this.

Reply to this email directly or view it on GitHub:
#4 (comment)

@tcrayford

This comment has been minimized.

Owner

tcrayford commented Oct 24, 2011

No worries. I like that this work might actually go somewhere.

Note I never really announced it on the clojure mailing list, but you might well want to at some point soon (though I still don't think some features [rename]) are ready for mainstream use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment