Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration is not calculated when running tests in sequence #210

Closed
sagatowski opened this issue Apr 29, 2023 · 4 comments
Closed

Duration is not calculated when running tests in sequence #210

sagatowski opened this issue Apr 29, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@sagatowski
Copy link
Member

sagatowski commented Apr 29, 2023

Describe the bug
Whenever running tests in sequence (any of the examples here, the duration is always calculated to be 0.0.

To Reproduce
Clone the latest master, run any of the examples above, and see the duration be 0.0.

Expected behavior
Duration should be correctly calculated, just like in the case when running tests that are not in sequence (so running in parallell).

Screenshots
image

Software versions
TwinCAT 3.1.4024.44.
Visual Studio 2019 (according to the contributing guidelines).
TcUnit from master.

Run environment
Running in virtual machine.

Additional context
Note that build-chain for TcUnit has been updated. Please look at Contributing markdown file.

@sagatowski sagatowski added the bug Something isn't working label Apr 29, 2023
@sagatowski
Copy link
Member Author

sagatowski commented Apr 29, 2023

@stefanbesler I just merged your changes in. Unfortunately, not everything works. See above. Could you look into it?
Note that the build-chain (tools) have been changed now (see contributing guidelines).

sagatowski added a commit that referenced this issue May 1, 2023
…sequence" and #211 "Duration doesn't seem to be correctly calculated".

Correction of PR #159 "Measure overall, testsuite and test duration".
@sagatowski
Copy link
Member Author

Initial fix done. Needs to be tested more. See #211 for the details.

@stefanbesler
Copy link
Contributor

Hm, not sure what went wrong here. What’s left to do, where can I help?

@sagatowski
Copy link
Member Author

Hey! I ran all the timed/sequence examples to verify everything is fine now and it looks good. I've realized it's a little annoying to run these manually to verify that the functionality is OK. Will have to think of a way to automate this.

@sagatowski sagatowski added this to the Release 1.3.0.0 milestone Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants