Wrong duration time (sometimes) calculated

[sagatowski]

Describe the bug
Sometimes the duration/time is wrongly calculated. This happens completely randomly and I have not been able to see why or any patterns. See screenshot below.

To Reproduce
Run tests over and over again. Eventually it will show up.

Screenshots

Software versions
Current master of TcUnit.
XAE 3.1.4024.50.
TcXaeShell.

Run environment
Virtual machine.

@stefanbesler

[sagatowski]

[stefanbesler]

Sorry, I am a bit busy at the moment, I can look into this somewhen next week.

Since this is so sporadic and the duration is off by such a large value, I think it has to do with this here

TcUnit/TcUnit/TcUnit/POUs/Functions/F_GetCpuCounterAs64bit.TcPOU

Line 14 in 4a48bdd

F_GetCpuCounterAs64bit := SHL(32, DWORD_TO_LWORD(CpuCounter.cpuCntHiDW)) + DWORD_TO_LWORD(CpuCounter.cpuCntLoDW);]]></ST>

This should most likely be

SHL(DWORD_TO_LWORD(CpuCounter.cpuCntHiDW), 32)

[TimSalzmann]

Can you give me a hint? I run TcUnit verifier 1.2.1.0 hand have 118 faild test is that correct? I want to simulate the random error.

[sagatowski]

@TimSalzmann

The expected behaviour is documented here:
https://github.com/tcunit/TcUnit/tree/master/TcUnit-Verifier

So to answer your question:

TcUnit/TcUnit-Verifier/TcUnit-Verifier_DotNet/TcUnit-Verifier/Program.cs

Line 21 in 4a48bdd

private static int expectedNumberOfFailedTests = 118; // Update this if you add intentionally failing tests

[stefanbesler]

Could reproduce it and solved it in the PR

[sagatowski]

Re-opening issue as the test-duration is still not calculated correctly for TEST_ORDERED(). See more details here:

• Duration not calculated for TEST_ORDERED() tests #228 and:
• Fix duration measurement on TEST_ORDERED and add unit tests for duration #231

Keeping this open until this issue is fully resolved to remember to close this for TcUnit 1.3.1.

[stefanbesler]

Maybe just revert the feature. I am not using TcUnit with ordered tests and I don’t have an example to debug the issue, it’s kinda hard for me to fix this, also I feels like ages since I worked on this. For a long time I am even mocking everything that is time dependent out of my tests to have all of them finish in 1 cyclic

[sagatowski]

Solved in #231.