-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "Audubon" to "Audiovisual" #252
Conversation
Occurrences in pdf, docs and /historical have not been renamed
Looks good to me. Thanks for doing this carefully. I was a little nervous of editing in older documents such as "termlist-2013-*" since in some sense it's a historical document too. But in the end I think this PR is a good compromise. We might want to make sure that the phrase "Audubon Core" does appear often enough in our materials, for search-engine purposes etc. |
I haven't had time to look this over carefully, but I don't think we should change the titles of the older versions. If we think we must, we can add a comment like "now called Audiovisual Core". But those versions may be cited by name and I don't think it's appropriate to change them after the fact. We also talked about having something on the website explaining about why we changed the name. But I don't think anybody has written that yet. It probably should be there before we "flip the switch". @rebeccasnyder @magpiedin were either of you thinking of writing this? |
Should I then revert the change in:
Are those files generated by code btw? Is an update in the code in this PR going to overwrite them anyway on a new build? Also, is there a need to release a:
|
I would say, yes, revert those unless others disagree. No, the new versions are generated by script, but currently the old versions are just archived by changing the name of the previously most recent version when the new one is added. The script appends the new terms metadata to a static header file so if the name is changed in that header file, it will automatically be included in all future code-generated pages. OK, I wrote about 5 paragraphs of junk ponderings and then just deleted them. Here is what I think we need to do:
Once that is done, then all subsequent new docs will be generated with the correct names. I think that's the simplest solution if we think that the name change spans new versions of the docs (which was what I convinced myself of in the 5 deleted paragraphs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I made a few comments in the diff. There was one change in code that would break something and a few comments about not changing two historical documents. I also did not comment on the various historical versions, which we discussed in the issue tracker and probably should be reverted. Otherwise I think all of the changes are OK.
@baskaufs I have done all the requested reverts. I'll leave the rest of your todo to you: #252 (comment) |
I also noticed that one link was changed, from: https://terms.tdwg.org/wiki/Audubon_Core Both currently give 504 for me |
@peterdesmet OK, thanks! I'm not sure that the terms.tdwg.org wiki is still operational, or what the long-term plans are for it. If it isn't going to be maintained, we should probably get rid of the link. I'll allow some time for @edwbaker to weigh in if he has any feedback. If not, in a few days I'll go ahead and generate the versions I mentioned and you should be able to merge the pull request. |
@peterdesmet I have created dated versions of all of the current standards documents in the master. That will put this branch a commit behind, but I don't think that should cause any conflict since the ones I created are all new documents. So I think you can just go ahead and do the merge now. When that's done, I'll update all of the dates in the headers of the (new) current versions to reflect the new issued date and link them back to the dated previous versions. |
@baskaufs Do I understand correctly that:
|
@peterdesmet You are entirely correct on 1-3. This is the model:
|
Ok, merged into |
Wiil do. I will try to fix the various metadata-related stuff later today. |
This PR changes every occurrence of
Audubon
toAudiovisual
.Audio-visual
has also been renamed toAudiovisual
. These changes only affects files in this repository, so more changes might be needed on e.g. the TDWG website.Exceptions
The change from
Audubon
toAudiovisual
has not been done for:File names
File names are not affected, except for:
Older versions of standard
This change does not retain the name "Audubon Core" anywhere, except when specifically referenced as "previously Audubon Core". That means that older versions of the standard have been affected as well:
@baskaufs @edwbaker @tdwg/ac please review carefully. I'd like to implement this change before updating the site design.