Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TG2-VALIDATION_SUBTRIBE_FOUND #208

Closed
chicoreus opened this issue Jul 3, 2023 · 4 comments
Closed

TG2-VALIDATION_SUBTRIBE_FOUND #208

chicoreus opened this issue Jul 3, 2023 · 4 comments
Labels
Conformance NAME Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@chicoreus
Copy link
Collaborator

chicoreus commented Jul 3, 2023 •
edited
Loading

TestField Value
GUID 4527c47e-61d9-4abb-af3e-f2999191be17
Label VALIDATION_SUBTRIBE_FOUND
Description Does the value of dwc:subtribe occur at rank of Subtribe in bdq:sourceAuthority?
TestType Validation
Darwin Core Class Taxon
Information Elements ActedUpon dwc:subtribe
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:subtribe is bdq:Empty; COMPLIANT if the value of dwc:subtribe is found as a value at the rank of subtribe in the bdq:sourceAuthority; otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions SUBTRIBE_FOUND
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "GBIF Backbone Taxonomy" [https://doi.org/10.15468/39omei]
API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]
Specification Last Updated 2023-09-22
Examples [dwc:subtribe="Malinae": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:subtribe has an equivalent at the rank of Subtribe in the bdq:sourceAuthority"]
[dwc:subtribe="Metazoa": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:subtribe does not strictly have an equivalent at the rank of Subtribe in the bdq:sourceAuthority"]
Source
References
Example Implementations (Mechanisms) Kurator/FilteredPush sci_name_qc Library
Link to Specification Source Code https://github.com/FilteredPush/sci_name_qc/blob/v1.1.2/src/main/java/org/filteredpush/qc/sciname/DwCSciNameDQ.java#L3686
Notes The purpose of this test is to check whether the value is a name that is a result of a nomenclatural act at this rank. This excludes unpublished names, misspellings and vernacular names. The same test might return distinct results when using distinct source authorities. This bdq:Supplementary test is not regarded as CORE (cf. bdq:CORE) because of one or more of the reasons: not being widely applicable; not informative; not straightforward to implement or likely to return a high percentage of either bdq:COMPLIANT or bdq:NOT_COMPLIANT results (cf bdq:Response.result). A Supplementary test may be implemented as CORE when a suitable use case exists.
@chicoreus chicoreus added TG2 Validation NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT NEEDS WORK Conformance labels Jul 3, 2023
@chicoreus
Copy link
Collaborator Author

Needs review. Parallels other validations that evaluate single higher rank terms. Entailed by tdwg/dwc#46

@chicoreus chicoreus added Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. and removed Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT NEEDS WORK labels Jul 5, 2023
@chicoreus
Copy link
Collaborator Author

After discussion in TG2, marking this as NOT CORE. This is the position we have taken for similar tests for other sub/super ranks.

Also, appears that a current implementation against the desired default bdq:sourceAuthority of GBIF's backbone taxonomy would return NOT_COMPLIANT for any non-empty dwc:subtribe values, as GBIF does not appear to have subtribe data in the backbone taxonomy.

@chicoreus
Copy link
Collaborator Author

See: #206 (comment)

@chicoreus chicoreus added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Sep 18, 2023
@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Sep 22, 2023 •
edited
Loading

Splitting Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated" deleted "Warning Type"

@Tasilee Tasilee closed this as completed Feb 6, 2024
@chicoreus chicoreus mentioned this issue Feb 15, 2024
Closed
chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jul 18, 2024
@chicoreus
Adding implementation of supplementary tests tdwg/bdq#206 tdwg/bdq#207 …
f89f5b2 
…and tdwg/bdq#208 not empty tests that evaluate recently added Dwarwin Core classification terms in the ranks superfamily, tribe, and subtribe, where the default GBIF backbone taxonomy does not yet provide data.  Including integration tests with cases that work in WoRMS, with GBIF cases that should return COMPLIANT, but don't, commented out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Conformance NAME Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chicoreus @Tasilee @ArthurChapman