Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_LOCATION_NOTEMPTY #40

Open
iDigBioBot opened this issue Jan 5, 2018 · 11 comments
Open

TG2-VALIDATION_LOCATION_NOTEMPTY #40

iDigBioBot opened this issue Jan 5, 2018 · 11 comments
Labels
Completeness CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 58486cb6-1114-4a8a-ba1e-bd89cfe887e9
Label VALIDATION_LOCATION_NOTEMPTY
Description Is there a value in any of the Darwin Core spatial terms that could specify a location?
TestType Validation
Darwin Core Class dcterms:Location
Information Elements ActedUpon dwc:higherGeographyID
dwc:higherGeography
dwc:continent
dwc:country
dwc:countryCode
dwc:stateProvince
dwc:county
dwc:municipality
dwc:waterBody
dwc:island
dwc:islandGroup
dwc:locality
dwc:locationID
dwc:verbatimLocality
dwc:decimalLatitude
dwc:decimalLongitude
dwc:verbatimCoordinates
dwc:verbatimLatitude
dwc:verbatimLongitude
dwc:footprintWKT
Information Elements Consulted
Expected Response COMPLIANT if at least one term needed to determine the location of the entity exists and is bdq:NotEmpty; otherwise NOT_COMPLIANT
Data Quality Dimension Completeness
Term-Actions LOCATION_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:locationID="https://opencontext.org/subjects/e54377f7-4452-4315-b676-40679b10c4d9", dwc:higherGeographyID="", dwc:higherGeography="", dwc:continent="", dwc:waterBody="", dwc:islandGroup="", dwc:island="", dwc:country="", dwc:countryCode="", dwc:stateProvince="", dwc:county="", dwc:municipality="", dwc:locality="", dwc:verbatimLocality="", dwc:decimalLatitude="", dwc:decimalLongitude="", dwc:coordinateUncertaintyInMeters="", dwc:geodeticDatum="", dwc:verbatimCoordinates="", dwc:verbatimLatitude="", dwc:verbatimLongitude="", dwc:footprintWKT="": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:LocationID is bdq:NotEmpty"]
[dwc:locationID="", dwc:higherGeographyID="", dwc:higherGeography="", dwc:continent="", dwc:waterBody="", dwc:islandGroup="", dwc:island="", dwc:country="", dwc:countryCode="", dwc:stateProvince="", dwc:county="", dwc:municipality="", dwc:locality="", dwc:verbatimLocality="", dwc:decimalLatitude="", dwc:decimalLongitude="", dwc:coordinateUncertaintyInMeters="", dwc:geodeticDatum="", dwc:verbatimCoordinates="", dwc:verbatimLatitude="", dwc:verbatimLongitude="", dwc:footprintWKT="": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="All location fields are bdq:Empty"]
Source Lee Belbin
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes Only fails if all of the relevant fields of the Darwin Core Location class are EMPTY or do not exist. Relevant Darwin Core fields include dwc:locationID, dwc:higherGeographyID, dwc:higherGeography, dwc:continent, dwc:waterBody, dwc:islandGroup, dwc:island, dwc:country, dwc:countryCode, dwc:stateProvince, dwc:county, dwc:municipality, dwc:locality, dwc:verbatimLocality, dwc:decimalLatitude, dwc:decimalLongitude, dwc:verbatimCoordinates, dwc:verbatimLatitude, dwc:verbatimLongitude, dwc:footprintWKT. Elevation and/or depth alone are deemed insufficient to meaningfully locate a position on the earth.
@iDigBioBot
Copy link
Collaborator Author

Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet:
I believe DwC terms should include some more, e.g., island, islandGroup, waterbody, county, municipality, continent, countryCode.

@ArthurChapman
Copy link
Collaborator

This is a complicated test - needs more work to document. Not georeferenced or not georeferenceable.. Need to add many dwc:terms. If all relevant spatial terms are blank or uninterpretable.

@ArthurChapman ArthurChapman added NEEDS WORK Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT and removed NEEDS WORK labels Jan 16, 2018
@chicoreus
Copy link
Collaborator

Extensive discussion in the meeting - has georeference or is georeferencable is one possible interpretation, but a very complex one to implement, and supported by other more granular tests. We decided to constrain this test to a simple test of minimal presence of some sort of spatial data.

@tucotuco tucotuco changed the title TG2-VALIDATION_LOCATION_NULL TG2-VALIDATION_LOCATION_EMPTY Jan 19, 2018
ArthurChapman added a commit that referenced this issue Oct 9, 2020
In accord with #189 added test data file for #40
@Tasilee
Copy link
Collaborator

Tasilee commented Feb 14, 2022

Going through the test data, I'm wondering if

dwc:minimumElevationInMeters
dwc:maximumElevationInMeters
dwc:minimumDepthInMeters
dwc:maximumDepthInMeters

should be included in Information Elements? @tucotuco did include the terms in the test data and some were NOT_EMPTY

@ArthurChapman
Copy link
Collaborator

I don't think I'd include them - except for a few minor exceptions, you can't tell a location on those alone.

@tucotuco
Copy link
Member

I agree from the perspective of a test for usable location information based on the Expected Response, "at least one term needed to determine the location of the entity."

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 20, 2022

OK. I've removed references to the depth and elevation terms from the test data.

@Tasilee Tasilee changed the title TG2-VALIDATION_LOCATION_EMPTY TG2-VALIDATION_LOCATION_NOTEMPTY Mar 22, 2022
@tucotuco
Copy link
Member

I suggest the Description:

'Is there a value in any of the Darwin Core spatial terms that could specify a location?'

in place of:

'Is there a value in any of the Darwin Core spatial terms that could identify a location?'

chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Jun 20, 2023
…st current (2023-06-12) test descriptions. Addressed implementation of tdwg/bdq#40 VALIDATION_LOCATION_EMPTY Adding ProvidesVersion annotations. Made method name consistent with test name.  Removing now empty file stubs for checked methods.  Adding to unit test.
@ArthurChapman
Copy link
Collaborator

Changed note to add the "dwc:" namespace to all the Darwin Core terms cited.

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 16, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted"

Also changed "Fields" to TestFields" and "Output Type" to "TestType", and will go back and add these to prior changes and then work forward

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 18, 2023

Changed all Information Elements to "ActedUpon" as per Paul's Java Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completeness CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Projects
None yet
Development

No branches or pull requests

5 participants