Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-ISSUE_IDENTIFICATIONQUALIFIER_DETECTED #97

Closed
iDigBioBot opened this issue Jan 5, 2018 · 14 comments
Closed

TG2-ISSUE_IDENTIFICATIONQUALIFIER_DETECTED #97

iDigBioBot opened this issue Jan 5, 2018 · 14 comments
Labels
Conformance Immature/Incomplete A test where substantial work is needed to develop the specification to the point where the test ca NAME Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 2eb62922-a8c6-4be7-aeef-56e1ca64c135
Label ISSUE_IDENTIFICATIONQUALIFIER_DETECTED
Description An identification qualifier was detected among relevant taxon terms
TestType ISSUE
Darwin Core Class Taxon
Information Elements ActedUpon dwc:scientificName
dwc:identificationQualifier
dwc:genericName
dwc:specificEpithet
dwc:infaspecificEpithet
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if the taxon name fields are bdq:Empty; ISSUE if any of the fields dwc:identificationQualifier, dwc:genericName, dwc:scientificName, dwc:specificEpithet or dwc:infraspecificEpithet contain an identification qualifier as in the bdq:sourceAuthority; otherwise NOT_ISSUE
Data Quality Dimension Conformance
Term-Actions IDENTIFICATIONQUALIFIER_DETECTED
Parameter(s) bdq:sourceAuthority
Specification Last Updated 2024-08-18
Source Authority bdq:sourceAuthority default = "Darwin Core dwc:identificationQualifier" {[https://dwc.tdwg.org/terms/#dwc:identificationQualifier]} {Unspecified vocabulary dwc:identificationQualifier}
Examples [dwc:scientificName="Thomomys cf. bottae", dwc:identificationQualifier="", dwc:genericName="", dwc:specificEpithet="", dwc:infraspecificEpithet="", Response.status=RUN_HAS_RESULT, Response.result=POTENTIAL_ISSUE, Response.comment="dwc:identificationQualifier is bdq:NotEmpty"]
[dwc:scientificName="Eucalyptus camaldulensis", dwc:identificationQualifier="", dwc:genericName="River Gum", dwc:specificEpithet="", dwc:infraspecificEpithet="", Response.status=RUN_HAS_RESULT, Response.result=NOT_ISSUE, Response.comment="An identification qualifier was not detected"]
Source VertNet
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes In this test "identification qualifier" has the meaning defined in the definition of dwc:identificationQualifier. dwc:genus is not included, as if a question mark is present in only genus but not scientific name, by the Darwin Core definition of genus, this expresses uncertainty about placement in the classification rather than identification. Can use a vocabulary to detect identificationQualifier as a token, but the resulting identificationQualifier need not necessarily follow a controlled vocabulary.
@iDigBioBot iDigBioBot added Issue A potential issue TG2 labels Jan 5, 2018
@iDigBioBot
Copy link
Collaborator Author

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet:
Needs vocab lookup then?

@ArthurChapman
Copy link
Collaborator

@chicoreus - that may need to be a different test - which is a NOTIFICATION and this one should be a VALIDATION (i.e. dwc:identificationQualifier is not NULL). Need to check if we have that one.

@ArthurChapman ArthurChapman added Validation VOCABULARY and removed Issue A potential issue labels Jan 18, 2018
@ArthurChapman ArthurChapman changed the title TG2-NOTIFICATION_IDENTIFICATIONQUALIFIER_DETECTED TG2-VALIDATION_IDENTIFICATIONQUALIFIER_DETECTED Jan 18, 2018
@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 18, 2018
@tucotuco tucotuco added the Parameterized Test requires a parameter label Nov 5, 2018
@ianengelbrecht
Copy link
Collaborator

Just a note on the note here, the current Darwin Core definition of genus doesn't include anything about the interpretation of question marks. Does this need to be added?

@ArthurChapman
Copy link
Collaborator

@ianengelbrecht - the note to the test mentions why we haven't included "?" in genus here - mainly because it could have two interpretations - 1) uncertainty in identification, 2) uncertainty in placement in heirarchy. One could argue that it was worth including and a flag, but at this stage we have agreed not to include.

@ArthurChapman
Copy link
Collaborator

If this test is kep then dwc:identificationQualifier needs to be included in the test.

@ArthurChapman
Copy link
Collaborator

As I note under #106 , I vote that we move that test and this one to Supplemental. Alternatively, I see some value in retaining this test to flag any record where the identification is suspect - identifying any of the terms listed in the @pzermoglio (final) list as a source Authority (except for "L." which is also used as the abbreviation for Linnaeus as an author) in any if the fields: dwc:scientificName, dwc:specificEpithet or dwc:infraspecificEpithet, or have a value in dwc:identificationQualifier.

@Tasilee
Copy link
Collaborator

Tasilee commented May 21, 2020

Thanks @ArthurChapman. Post discussions today, the key issue is how many false negatives that would result from this VALIDATION; returning COMPLIANT when the record contained some form of identification qualifier.

@pzermoglio 's research suggests > 1000 variants of characters that may indicate an identification qualifier. If it was a long tail distribution where say 10 character combinations detected ~90%, then maybe this would be a useful VALIDATION.

I also don't understand why this VALIDATION is not using dwc:identifictionQualifier. (This may have been raised in our tele today and was indeed mentioned by @ArthurChapman above).

Pondering. Votes by COB May 26 please.

@tucotuco
Copy link
Member

tucotuco commented May 21, 2020 via email

@Tasilee Tasilee added the Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. label May 25, 2020
@Tasilee Tasilee closed this as completed May 25, 2020
@chicoreus
Copy link
Collaborator

I concur with moving this test from core to supplemental. Implementation of effective detection of an identification qualifier, when the identificationQualifier term is empty, is non-trivial, and it is unclear what data quality needs are addressed that would not be addressed by the consumer of the data asking a simple question such as is identificationQualifier empty and specificEpithet contains exactly one word.

@ArthurChapman ArthurChapman removed the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Sep 18, 2023
@chicoreus chicoreus added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Sep 18, 2023
@chicoreus chicoreus changed the title TG2-VALIDATION_IDENTIFICATIONQUALIFIER_DETECTED TG2-ISSUE_IDENTIFICATIONQUALIFIER_DETECTED Feb 20, 2024
@chicoreus
Copy link
Collaborator

Rephrasing as issue, updating markdown table to more closely conform with current usage. Marking as immature given absence of controlled vocabulary and discussion of immaturity above.

@chicoreus chicoreus added Immature/Incomplete A test where substantial work is needed to develop the specification to the point where the test ca and removed Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Feb 20, 2024
@ArthurChapman
Copy link
Collaborator

Example needs updating to conform with current usage.

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 21, 2024

Added examples to conform to current template

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 22, 2024

Changed Test to TestField and added Description

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Standardized reference to "EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available" in Expected Response and tried to standardize bdq:sourceAuthority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conformance Immature/Incomplete A test where substantial work is needed to develop the specification to the point where the test ca NAME Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY
Projects
None yet
Development

No branches or pull requests

6 participants