Repository navigation
Request: could the Flutter/Dart Spotube 5.1.x be relicensed (e.g. AGPL-3.0), and a license for NewPipeCLI? #3164
MattoMatteo
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi Kingkor,
first of all, thank you for Spotube. I've been using it every day for a long time.
Context
I use Spotube 5.1.2 (the Flutter version) on Windows. The new Kotlin nightly crashes at startup on
my PC (in
nucleus_tao.dll), so I kept using 5.1.2 and, since the Dart version isn't developedanymore, I made a fork with some fixes for my own use and to share for free with a few friends:
patched-5.1.2, based on tagv5.1.2)Out of respect for clause 4 of the BSD-4-Clause license, the fork is called Matubefy and doesn't
use the Spotube name to promote itself. The copyright notice, the license and the credits are kept
(the About page says "Based on Spotube" and still credits you as the founder), and the README carries
"This product includes software developed by Kingkor Roy Tirtho."
What I changed, in case anything is useful to you:
radio()calls interleaved duplicated tracks into the queue.duration 59 times vs 47 for videos; YouTube's anonymous video search also returns nothing for
some words, e.g. "X-Rated"), with videos as fallback;
VideoInfo/VideoSearchResultItemno longer throw on reduced YouTube responses or on musicresults without
uploaderUrl(one such item used to fail the whole search);?("PAVÉ" → "PAV?"), andits UTF-8 output was decoded with the system code page: NewPipeCLI now accepts
--search-b64and always writes UTF-8;
youtubeClientEngine,so the column default (YouTubeExplode) applied instead of
PreferencesTable.defaults().The license question
While preparing to share it, I noticed a licensing problem that I can't solve myself:
Spotube 5.1.x is BSD-4-Clause, and the advertising clause makes it incompatible with the
GPL. On Android,
flutter_new_pipe_extractorlinks NewPipeExtractor (GPL-3.0) into the APK,so the app as distributed can't satisfy both licenses at once. (On desktop it's fine, NewPipeCLI
is a separate executable.) I saw that the Kotlin rewrite is AGPL-3.0, which solves this there.
I read your article "Choosing open source license wisely"
and I understand that the credit requirement is the reason you chose BSD-4-Clause. That's why
my fork keeps the credits everywhere (README, About page, release notes), it's free, and the
source is public. Two ideas that would keep your credit requirement:
require that your author attribution is preserved, so the credit can stay mandatory; or
with NewPipeExtractor (GPL-3.0), which would only solve the Android case.
Whichever you prefer (or any other option, e.g. BSD-3-Clause), a short statement in a reply here,
or an updated LICENSE on
master, would be enough.NewPipeCLI has no license file. Could you add one? Since it bundles NewPipeExtractor
(GPL-3.0), GPL-3.0 would be the natural choice.
Is it OK for you that the fork says it is "based on Spotube" in the README and the About page,
as it does now?
If any of the fixes above is useful, I'm happy to open pull requests (NewPipeCLI's
--search-b64and the NewPipeExtractor update in particular are independent of Spotube).
Thanks again for your work, and good luck with the Kotlin version!
Matteo (MattoMatteo)
All reactions