Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 compatibility via 2to3 #102

Merged

Conversation

fmessmer
Copy link
Contributor

we are currently running pylint/pylint3 test against our code and found a few errors in this repo
the changes were produced by running 2to3 -wn .

@LoyVanBeek @benmaidel FYI

@fmessmer fmessmer changed the base branch from master to develop January 27, 2020 14:41
@pschillinger
Copy link
Member

Thanks for cleaning this up! I just removed a few redundancies and will merge now.

@pschillinger pschillinger merged commit 36663f4 into team-vigir:develop Feb 1, 2020
@fmessmer fmessmer deleted the feature/python3_compatibility branch February 3, 2020 10:39
@pschillinger pschillinger mentioned this pull request Jun 5, 2020
@dcconner
Copy link
Member

@pschillinger @fmessmer Question. This PR changed the Python queue to use python-six six.moves.Queue.

Why? What does six.moves.queue have over just standard queue module?

I'd like to go back to queue to avoid issue on ROS 2 release as RHEL does not have python-six.
Or is there some reason for python-six, and should I convert dependency to python3-six? or just drop RHEL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants