Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic import statements #1554

Closed
manuel-minniti opened this issue Apr 17, 2019 · 3 comments
Closed

Dynamic import statements #1554

manuel-minniti opened this issue Apr 17, 2019 · 3 comments

Comments

@manuel-minniti
Copy link

Expected Behavior

I expect the bit client to not report any issues on the component that contains dynamic import statements.

Actual Behavior

Bit client says there are issues with the component.

missing packages dependencies (use your package manager to make sure all package dependencies are installed):
src/react/private/ComponentDetailPage/ComponentDetailPage.js -> undefined

Steps to Reproduce the Problem

  1. Create a component with a dynamic import statement i.e.
<LazyLoadModule
     resolve={() => import(`../../${path}/${props.name}/${props.name}.demo.js`)}
   />
  1. Run bit status, you should see an error now

Specifications

  • Bit version: 14.0.3
  • Node version:v10.15.0
  • npm / yarn version:6.8.0
  • Platform: Mac OSX (Mojave)
  • Bit compiler (include version):
  • Bit tester (include version):
@GiladShoham
Copy link
Member

@manuel-minniti Thanks for reporting this.
This is a bug and we are looking into it right now.
I'll post an update with my findings.

@davidfirst
Copy link
Member

Reopening the ticket. Will be closed once the fix is released.
The PR is merged into master.

@davidfirst davidfirst reopened this Apr 17, 2019
@davidfirst
Copy link
Member

v14.1.0 has been released with the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants