fix bit export to not export non-staged dependencies #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build bit 1.0.9059 failed (commit 903048565f by @davidfirst) |
GiladShoham
added a commit
that referenced
this pull request
Feb 9, 2020
* fix #2211 and #2308, when exporting to multiple scopes, make sure to not export their dependencies when these dependencies themselves are not export pending (#2309) * resolve #2268, prevent logger from holding the terminal once a command is completed by adding an error handler. Also, changed some "logger.debug" to "logger.silly". Also, support configuring the logger level by running "bit config set log_level <level>". Also, limit the number of concurrent files write to 100 (#2310) * fix typo in the BitId README * fix "bit status" and "bit tag" when new components require each other by module paths (#2313) Co-authored-by: David First <david@bit.dev>
davidfirst
added a commit
that referenced
this pull request
Feb 17, 2020
* fix #2211 and #2308, when exporting to multiple scopes, make sure to not export their dependencies when these dependencies themselves are not export pending (#2309) * bump dev version * resolve #2268, prevent logger from holding the terminal once a command is completed by adding an error handler. Also, changed some "logger.debug" to "logger.silly". Also, support configuring the logger level by running "bit config set log_level <level>". Also, limit the number of concurrent files write to 100 (#2310) * fix typo in the BitId README * fix "bit status" and "bit tag" when new components require each other by module paths (#2313) * Fix e2e-tests to avoid code execution inside "describe" blocks (#2329) * move all Helper instantiation from describe to before. * fix defaultScope tests, remove code that was entered by mistake in the describe block to before block. * delete javascript-hook.e2e file, the tests there were written long ago, marked as "skip" and not relevant anymore. * support import/require statements of module paths when it has no scope-name (e.g. "@bit/button") (#2331) * resolve part of #2341, enable "--all" flag when "--all-versions" is used and vice versa, to enable re-exporting a component after deleting it (#2345) * Fixed broken link leading to quick start guide (#2338) * fix dynamic dist reference from package.json (#1808) when isolating via capsule (#2348) * remove .only from extension tests Co-authored-by: Erik <arebokert@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happens when exporting to multiple scopes (by running
bit exportwith no id).The bug was related to the graph built to make sure the export is done in topological order. This graph contains all dependencies of the pending-export components.
After the sort, Bit was trying to export these dependencies as well although they were not export-pending.
Fixes #2211 and #2308 .
This change is