-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: root components are grouped by envs and apps #6800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkochan
force-pushed
the
root-comps
branch
2 times, most recently
from
January 10, 2023 12:40
509a1bb
to
913a0e3
Compare
zkochan
force-pushed
the
root-comps
branch
3 times, most recently
from
January 26, 2023 06:20
10636b7
to
ca1db4c
Compare
davidfirst
previously approved these changes
Jan 26, 2023
zkochan
force-pushed
the
root-comps
branch
5 times, most recently
from
January 30, 2023 17:06
6b8104b
to
9f92486
Compare
zkochan
force-pushed
the
root-comps
branch
4 times, most recently
from
February 1, 2023 22:08
dbc9156
to
d35b8e2
Compare
zkochan
force-pushed
the
root-comps
branch
2 times, most recently
from
February 5, 2023 14:27
30db62e
to
5ccb22e
Compare
GiladShoham
approved these changes
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
.bit_roots
in the root of your node_modules folder.This folder will contain a sub-folder for 2 entities:
These folders under the
.bit_roots
are called root components. each one of them represents a root.Each root will have links to all components in the workspace with the peer dependencies resolved from the root entity.
for example, if you have an env that sets React to v18 and another root that sets React to v17, the version of react will be determined by the version of the root component.
so a button created in the react 17 env when used inside a composition of components created by a react 18 env will get react v18 at runtime.
While in the composition of itself, it will get react 17 at runtime.
Here is an example of the top level structure of the
.bit_roots
folder when root components is enabled- Here is an example of the structure of one of the root components