fix: add missing flattened and edges to new snap/tag #6848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
approved these changes
Dec 29, 2022
zkochan
pushed a commit
that referenced
this pull request
Jan 5, 2023
Due to some previous bugs, some components might have missing flattened dependencies. As a result, the flattenedEdges may have more components than the flattenedDependencies, which will cause issues later on when the graph is built. This fixes it by adding the missing flattened dependencies, and then recursively adding the flattenedEdge accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some previous bugs, some components might have missing flattened dependencies. As a result, the flattenedEdges may have more components than the flattenedDependencies, which will cause issues later on when the graph is built.
This fixes it by adding the missing flattened dependencies, and then recursively adding the flattenedEdge accordingly.