Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure to not add components set with bit deps set as packages #6945

Merged
merged 4 commits into from
Jan 23, 2023
Merged

make sure to not add components set with bit deps set as packages #6945

merged 4 commits into from
Jan 23, 2023

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Jan 23, 2023 •
edited
Loading

Proposed Changes

  • make sure to not add components set with bit deps set as packages
  • use getIssueByName instead of getIssue to prevent bit from bvm and from repo compatibility

guysaar223
guysaar223 previously approved these changes Jan 23, 2023
View reviewed changes
@GiladShoham GiladShoham enabled auto-merge (squash) January 23, 2023 11:32
@GiladShoham GiladShoham merged commit edee676 into master Jan 23, 2023
@GiladShoham GiladShoham deleted the bug-comp-deps-manually branch January 23, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

@guysaar223 guysaar223 guysaar223 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GiladShoham @zkochan @guysaar223