Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove not needed utils #7070

Merged
merged 3 commits into from
Feb 22, 2023
Merged

refactor: remove not needed utils #7070

merged 3 commits into from
Feb 22, 2023

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Feb 21, 2023 •
edited
Loading

Proposed Changes

  • use p-filter
  • use lodash.partition instead of splitBy from our utils
  • use [0] instead of first from our utils
  • use native .flat() function

GiladShoham
GiladShoham previously approved these changes Feb 21, 2023
View reviewed changes
@zkochan zkochan force-pushed the refactor-legacy-utils6 branch 2 times, most recently from 3fcb8d8 to 6b58ebc Compare February 22, 2023 10:55
@zkochan zkochan enabled auto-merge (squash) February 22, 2023 12:57
@zkochan zkochan merged commit d609eb6 into master Feb 22, 2023
@zkochan zkochan deleted the refactor-legacy-utils6 branch February 22, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkochan @GiladShoham