fix(preview): notify parent from iframe when preview is not available #8778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where the preview loader would continue to display indefinitely in scenarios where the preview is not found. Previously, the system failed to notify the preview loader upon the iframe's completion of the mounting process, leading to situations where users would not receive feedback that the preview is unavailable. With the proposed changes, the system now correctly signals the preview loader upon iframe mount, even in cases where the preview content is missing, ensuring that the loader is dismissed and users are informed of the unavailability of the preview.
Pending CR: https://bit.cloud/teambit/ui-foundation/~change-requests/notify-parent
Screen.Recording.2024-04-11.at.3.39.11.PM.mov