-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lampei conflicts to add WebDriver #25
Merged
ddspringle
merged 23 commits into
teamcfadvance:master
from
jamiejackson:fix_lampei_conflicts
Jun 1, 2016
Merged
Fix lampei conflicts to add WebDriver #25
ddspringle
merged 23 commits into
teamcfadvance:master
from
jamiejackson:fix_lampei_conflicts
Jun 1, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new unit tests. Added runners for tests in CF7, CF8, CF9, and the version 2 items. Renamed cf8 tests so that runner would automatically find them based on their name.
Added 32 and 64 bit Internet Explorer drivers Created objects corresponding to various web drivers Renamed cf8 tests for automatic pickup by MXUnit runner Added runners for cf7 and cf8 tests Added unit tests for version 2 files Renamed version 1 selenium object to webSelenium
Changed local references and used google.com Switch tests to use firefox instead of IE for easier user testing
…ver and InternetExplorerDriver
… that it loads on server start
fix_lampei_conflicts # Conflicts: # CFSeleniumTestCase.cfc # selenium.cfc # selenium_tags.cfc # server.cfc # test/cf7_cf8/cf8_waitForTest.cfc # test/cf7_cf8/waitForTest_cf7.cfm # test/cf9/readmeTest.cfc # test/cf9/waitForTest.cfc
lib; upgraded IE driver; replaced brittle google.com tests with local fixture;
jamiejackson
changed the title
Fix lampei conflicts
Fix lampei conflicts to add WebDriver
May 31, 2016
This was referenced May 31, 2016
Merged
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lampei's old pull request languished due to conflicts.
Unfortunately, as far as I know, this project has no documentation around how to run its own tests (how to configure environments, which to run, etc.). Therefore, I set out to make these two runners pass:
test/cf9/run.cfm
- Selenium-RC: Runs on Lucee 4 and ACF11.test/v2/run.cfm
- WebDriver: Runs on Lucee 4 and ACF11.I've managed to resolve the conflicts, fix some brittle old tests, update some libraries, and fix some cross-engine compatibility problems.
Caveats
I figure none of these should preclude a merge, but here they are.
administrator
_, in order to get local IE tests working properly -java -jar e:\www\cfselenium\Selenium-RC\selenium-server-standalone-2.53.0.jar
. Otherwise, I get errors* during the IE tests.test/v2/run.cfm
(WebDriver) tests only work on ACF11+. On lower versions, I get errors** that seem to point to old, incompatible versions ofhttpclient
. I'm not going to bother to get all that up and running in another class loader (since I don't even use ACF), but someone else can look into that later.* IE problem when server not run as admin
Despite trying to disable all popup blocking, I got:
Location bar shows something like this:
C:\Users\15037\AppData\Local\Temp\customProfileDir8ebab3bd6c3b404e8b0678899ba0f205\core\Blank.html
...and an error dialog of:
** ACF 10- problems with WebDriver