Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom attribute bugfix #549

Merged
merged 3 commits into from Dec 2, 2020
Merged

Custom attribute bugfix #549

merged 3 commits into from Dec 2, 2020

Conversation

michielderoos
Copy link
Contributor

@michielderoos michielderoos commented Nov 16, 2020

Describe the Pull Request

If an org had no CA's, there was a crash when loading the account page. Fixes!

Todo

  • Link relevant trello card or related issue to the pull request
  • Request review from relevant @person or team
  • QA your pull request. This includes running the app, login, testing changes etc.
  • Bump backend and/or frontend versions following Semver

@michielderoos
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #549 (6894c0f) into master (491c8ee) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #549   +/-   ##
=======================================
  Coverage   47.26%   47.26%           
=======================================
  Files         331      331           
  Lines       17200    17200           
  Branches     1336     1337    +1     
=======================================
  Hits         8129     8129           
+ Misses       9056     9038   -18     
- Partials       15       33   +18     
Flag Coverage Δ
javascript 4.78% <0.00%> (ø)
python 71.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/client/components/user/EditUserForm.tsx 0.00% <0.00%> (ø)
app/client/reducers/auth/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/user/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/wyre/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/filter/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/metric/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/auth/loginReducer.ts 0.00% <0.00%> (ø)
app/client/components/helpers/responsive.tsx 0.00% <0.00%> (ø)
app/client/reducers/organisation/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/allowedFilters/reducers.ts 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491c8ee...6894c0f. Read the comment docs.

Copy link
Contributor

@tristanhcole tristanhcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!🐞

@michielderoos michielderoos merged commit 917b387 into master Dec 2, 2020
@michielderoos michielderoos deleted the custom-attribute-bugfix branch December 2, 2020 13:14
enjeyw added a commit that referenced this pull request Dec 3, 2020
* master:
  Silence loading spinner warning (#568)
  Custom attribute bugfix (#549)
  Antify Message Bar (#566)
  Stop retrying infinitely (#565)
  Only update BlockchainTransaction on the worker when we absolutely have to (#564)
  Make SynchronizedBlock be updated in batch instead of one giant update (#563)
  Hide Filters and Groups (#558)
  adding more colors to charts, and tweaking legends (#561)
  Chart Tweaks (#560)
  Recipients filter (#533)
  Dynamic transfer card loaded (#559)
  multi-line notes (#556)
  Add indexes to eth_worker database (#545)

# Conflicts:
#	config.py
enjeyw added a commit that referenced this pull request Dec 3, 2020
* master:
  Silence loading spinner warning (#568)
  Custom attribute bugfix (#549)
  Antify Message Bar (#566)
  Stop retrying infinitely (#565)
  Only update BlockchainTransaction on the worker when we absolutely have to (#564)
  Make SynchronizedBlock be updated in batch instead of one giant update (#563)
  Hide Filters and Groups (#558)
  adding more colors to charts, and tweaking legends (#561)
  Chart Tweaks (#560)
  Recipients filter (#533)
  Dynamic transfer card loaded (#559)
  multi-line notes (#556)
  Add indexes to eth_worker database (#545)
  Changes to custom attributes (#540)
  Rewrite custom attribute filters (#552)
enjeyw added a commit that referenced this pull request Dec 7, 2020
* master:
  feat: small improvements to accessibility across the web app (#562)
  Group by Sender and Recipient (#567)
  Enable multiple chains (#496)
  Silence loading spinner warning (#568)
  Custom attribute bugfix (#549)
  Antify Message Bar (#566)

# Conflicts:
#	config.py
#	eth_worker/eth_src/celery_app.py
#	eth_worker/eth_src/sql_persistence/interface.py
enjeyw added a commit that referenced this pull request Dec 15, 2020
* master: (28 commits)
  Adding blockchain_task_uuid index to worker messages (#551)
  Make location lookup look at existing users' coordinates as a last resort (#555)
  Add support for Commcare (#569)
  Improve external transaction detection (#570)
  Remove unused imports (#571)
  Celo integration (#535)
  feat: small improvements to accessibility across the web app (#562)
  Group by Sender and Recipient (#567)
  Enable multiple chains (#496)
  Silence loading spinner warning (#568)
  Custom attribute bugfix (#549)
  Antify Message Bar (#566)
  Stop retrying infinitely (#565)
  Only update BlockchainTransaction on the worker when we absolutely have to (#564)
  Make SynchronizedBlock be updated in batch instead of one giant update (#563)
  Hide Filters and Groups (#558)
  adding more colors to charts, and tweaking legends (#561)
  Chart Tweaks (#560)
  Recipients filter (#533)
  Dynamic transfer card loaded (#559)
  ...

# Conflicts:
#	app/server/api/transfer_card_api.py
#	app/test_app/functional/api/test_transfer_card_api.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants