Only update BlockchainTransaction on the worker when we absolutely have to #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 47.34% 47.34% -0.01%
==========================================
Files 337 337
Lines 17262 17263 +1
Branches 1284 1284
==========================================
Hits 8173 8173
- Misses 9074 9075 +1
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
enjeyw
approved these changes
Nov 26, 2020
enjeyw
added a commit
that referenced
this pull request
Nov 30, 2020
* master: Stop retrying infinitely (#565) Only update BlockchainTransaction on the worker when we absolutely have to (#564) Make SynchronizedBlock be updated in batch instead of one giant update (#563) Hide Filters and Groups (#558) adding more colors to charts, and tweaking legends (#561) Chart Tweaks (#560) Recipients filter (#533) Dynamic transfer card loaded (#559) multi-line notes (#556) Add indexes to eth_worker database (#545) Changes to custom attributes (#540) Rewrite custom attribute filters (#552)
enjeyw
added a commit
that referenced
this pull request
Dec 3, 2020
* master: Silence loading spinner warning (#568) Custom attribute bugfix (#549) Antify Message Bar (#566) Stop retrying infinitely (#565) Only update BlockchainTransaction on the worker when we absolutely have to (#564) Make SynchronizedBlock be updated in batch instead of one giant update (#563) Hide Filters and Groups (#558) adding more colors to charts, and tweaking legends (#561) Chart Tweaks (#560) Recipients filter (#533) Dynamic transfer card loaded (#559) multi-line notes (#556) Add indexes to eth_worker database (#545) # Conflicts: # config.py
enjeyw
added a commit
that referenced
this pull request
Dec 3, 2020
* master: Silence loading spinner warning (#568) Custom attribute bugfix (#549) Antify Message Bar (#566) Stop retrying infinitely (#565) Only update BlockchainTransaction on the worker when we absolutely have to (#564) Make SynchronizedBlock be updated in batch instead of one giant update (#563) Hide Filters and Groups (#558) adding more colors to charts, and tweaking legends (#561) Chart Tweaks (#560) Recipients filter (#533) Dynamic transfer card loaded (#559) multi-line notes (#556) Add indexes to eth_worker database (#545) Changes to custom attributes (#540) Rewrite custom attribute filters (#552)
enjeyw
added a commit
that referenced
this pull request
Dec 15, 2020
* master: (28 commits) Adding blockchain_task_uuid index to worker messages (#551) Make location lookup look at existing users' coordinates as a last resort (#555) Add support for Commcare (#569) Improve external transaction detection (#570) Remove unused imports (#571) Celo integration (#535) feat: small improvements to accessibility across the web app (#562) Group by Sender and Recipient (#567) Enable multiple chains (#496) Silence loading spinner warning (#568) Custom attribute bugfix (#549) Antify Message Bar (#566) Stop retrying infinitely (#565) Only update BlockchainTransaction on the worker when we absolutely have to (#564) Make SynchronizedBlock be updated in batch instead of one giant update (#563) Hide Filters and Groups (#558) adding more colors to charts, and tweaking legends (#561) Chart Tweaks (#560) Recipients filter (#533) Dynamic transfer card loaded (#559) ... # Conflicts: # app/server/api/transfer_card_api.py # app/test_app/functional/api/test_transfer_card_api.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Whenever we update
BlockchainTransaction, the/api/v1/blockchain_taskablewebhook is called. The problem is that we updateBlockchainTransactionwhen we don't have to a lot of the time (like when the state changes fromPENDINGtoPENDING), leading to a bunch of webhook calls that don't ever really have to happen. This tests to make sure that we need to update, before we actually do!Todo