New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: small improvements to accessibility across the web app #562
Conversation
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
==========================================
- Coverage 47.27% 47.24% -0.04%
==========================================
Files 338 338
Lines 17560 17574 +14
Branches 1345 1347 +2
==========================================
+ Hits 8301 8302 +1
- Misses 9226 9257 +31
+ Partials 33 15 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
color: "#6a7680" | ||
color: "#4e575e" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improves colour contrast to be AAA https://www.a11yproject.com/checklist/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# Conflicts: # app/package.json
* master: feat: small improvements to accessibility across the web app (#562) Group by Sender and Recipient (#567) Enable multiple chains (#496) Silence loading spinner warning (#568) Custom attribute bugfix (#549) Antify Message Bar (#566) # Conflicts: # config.py # eth_worker/eth_src/celery_app.py # eth_worker/eth_src/sql_persistence/interface.py
* master: (28 commits) Adding blockchain_task_uuid index to worker messages (#551) Make location lookup look at existing users' coordinates as a last resort (#555) Add support for Commcare (#569) Improve external transaction detection (#570) Remove unused imports (#571) Celo integration (#535) feat: small improvements to accessibility across the web app (#562) Group by Sender and Recipient (#567) Enable multiple chains (#496) Silence loading spinner warning (#568) Custom attribute bugfix (#549) Antify Message Bar (#566) Stop retrying infinitely (#565) Only update BlockchainTransaction on the worker when we absolutely have to (#564) Make SynchronizedBlock be updated in batch instead of one giant update (#563) Hide Filters and Groups (#558) adding more colors to charts, and tweaking legends (#561) Chart Tweaks (#560) Recipients filter (#533) Dynamic transfer card loaded (#559) ... # Conflicts: # app/server/api/transfer_card_api.py # app/test_app/functional/api/test_transfer_card_api.py
Describe the Pull Request
This PR implements/fixes most, but not all, items in the a11yproject checklist for WCAP compliance. The main items that haven't been implemented are
keyboard
,table
&control
(due to ant design accessibility constraints).Todo