Remove unused imports #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 47.23% 47.19% -0.05%
==========================================
Files 338 337 -1
Lines 17589 17575 -14
Branches 1348 1348
==========================================
- Hits 8309 8295 -14
Misses 9247 9247
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tristanhcole
approved these changes
Dec 7, 2020
app/server/api/transfer_usage_api.py
Outdated
| @@ -1,7 +1,6 @@ | |||
| from flask import Blueprint, request, make_response, jsonify | |||
| from flask.views import MethodView | |||
| from sqlalchemy import desc | |||
There was a problem hiding this comment.
from sqlalchemy import desc is also unused it seems?
There was a problem hiding this comment.
Hm, vulture didn't pick those up for some reason. Will delete when I log on in the AM!
app/server/utils/amazon_s3.py
Outdated
| @@ -1,12 +1,10 @@ | |||
| import os | |||
| import shutil | |||
| import requests | |||
| import datetime | |||
| from flask import g, current_app | |||
| import boto3 | |||
There was a problem hiding this comment.
import boto3 also unused
Comment on lines
-150
to
-172
|
|
||
| transaction_volume_filters = [ | ||
| CreditTransfer.transfer_status == TransferStatusEnum.COMPLETE, | ||
| ] | ||
|
|
||
| standard_payment_filters = [ | ||
| CreditTransfer.transfer_status == TransferStatusEnum.COMPLETE, | ||
| CreditTransfer.transfer_type == TransferTypeEnum.PAYMENT, | ||
| CreditTransfer.transfer_subtype == TransferSubTypeEnum.STANDARD | ||
| ] | ||
|
|
||
| exchanged_filters = [ | ||
| CreditTransfer.transfer_status == TransferStatusEnum.COMPLETE, | ||
| CreditTransfer.transfer_type == TransferTypeEnum.EXCHANGE, | ||
| ] | ||
|
|
||
| beneficiary_filters = [User.has_beneficiary_role == True] | ||
| vendor_filters = [User.has_vendor_role == True] | ||
|
|
||
| exhaused_balance_filters = [ | ||
| CreditTransfer.transfer_type == TransferTypeEnum.PAYMENT, | ||
| TransferAccount._balance_wei == 0 | ||
| ] |
There was a problem hiding this comment.
would these be used in future?
There was a problem hiding this comment.
I don't imagine they will be.They're pretty self explanatory to rewrite if we do though IMO
enjeyw
added a commit
that referenced
this pull request
Dec 15, 2020
* master: (28 commits) Adding blockchain_task_uuid index to worker messages (#551) Make location lookup look at existing users' coordinates as a last resort (#555) Add support for Commcare (#569) Improve external transaction detection (#570) Remove unused imports (#571) Celo integration (#535) feat: small improvements to accessibility across the web app (#562) Group by Sender and Recipient (#567) Enable multiple chains (#496) Silence loading spinner warning (#568) Custom attribute bugfix (#549) Antify Message Bar (#566) Stop retrying infinitely (#565) Only update BlockchainTransaction on the worker when we absolutely have to (#564) Make SynchronizedBlock be updated in batch instead of one giant update (#563) Hide Filters and Groups (#558) adding more colors to charts, and tweaking legends (#561) Chart Tweaks (#560) Recipients filter (#533) Dynamic transfer card loaded (#559) ... # Conflicts: # app/server/api/transfer_card_api.py # app/test_app/functional/api/test_transfer_card_api.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Been playing with vulture, and thought I should do a super quick PR to get rid of some unused imports.
Todo