Skip to content

Conversation

techniq
Copy link
Owner

@techniq techniq commented Oct 5, 2024

No description provided.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Oct 5, 2024

🦋 Changeset detected

Latest commit: 0606482

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-ux Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@techniq techniq merged commit 9056efc into main Oct 5, 2024
2 checks passed
@techniq techniq deleted the form-submit branch October 5, 2024 15:26
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
@kasleet
Copy link
Contributor

kasleet commented Oct 6, 2024

@techniq Thanks for the quick response and PR! I tried it and it works as expected, but I think this somehow broke the client-side form handling? At least for me using 0.75.0, the state is not updated anymore, using 0.74.9 works as expected. I would exclude the possibility that I have some bug in my code, but maybe you can have a look, to make sure its still working?

Edit 3: The client-side form handling when using a zod schema is broken. You added a "return true" when the zod schema validation succeeds. This is fine for server form submissions, but for the client-side form handling, the state and draft stores are now never updated.

@kasleet
Copy link
Contributor

kasleet commented Oct 6, 2024

I created a PR which fixes the problem, but I don't know if you like this structure: #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants