fix(#330): Add OSM attribution #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelino
changed the title
|
ja sieht gut aus so. nebst der karte ist das allgemein gut so. |
|
@joshinils Thanks for your input. Very much appreciated |
ff6347
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add the correct OpenStreetMap attribution to the map, as indicated by @joshinils on #330. I followed a combination of the OSM attribution guideline and the Mapbox attribution guideline, but I'm not 100% sure if my implementation fulfills your requirements @joshinils. So let me know.
Edit: I also added the Mapbox attribution and logo. Now we should be fine.