Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Adding informedk12 event photos #92

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

fvntr
Copy link
Collaborator

@fvntr fvntr commented Oct 19, 2018

Adding informedk12 photos


✅️ By submitting this PR, I have verified the following

@ghost ghost assigned fvntr Oct 19, 2018
@ghost ghost added the review This issue is under review - used by Waffle.io tracker label Oct 19, 2018
date: 2018-08-15
link: https://photos.app.goo.gl/hQM9G7ssbjvvcBTZ8
description: A night of networking and learning about what it means to be on the frontlines of EdTech
image: https://lh3.googleusercontent.com/0ulxucEL1a5gG2fw5udYf_UlGhLbLZHhT3qhnUkhBHBhBFk3M9zLQDpBTL27Cl-GBCyuJukucwhJaCelKbrgWoIPD-sdt-gdDjGlaTplOQHrIZotHJY3HaB8sznlxVHmIBMWSr7Hncb-4QCqC9q3InNMi97Wj5TRrykJdVZfd1Ei9kqKCjjlnlrQg_ifRjKxksIJyaJhNvmDsOoQpAG9vDcH72Ricjv5S-NR8Zvy7mLW7F2FPSYfg8Bwhh7cpts1UanPNqBv1whjDcsnJ_hyS9nHb6k84ANuBJEEaO2sFFckpCF_Rpl8xOtwH8k6t6QIZVBV3Ke5v_n_599C_XGBQlo8GLX_AP18Tst9kVnBCMJVvPb_NAijslCF0Zc3tXAV-FNsT7kF9XERIISnL0KJexW1bBTlh8mVBO89j_krcoDqMkg_a6-ol2_YZOS7Mfymp2KbcCcYw9J934XcDmWbKE8KFSeGH5XUIVnhotQyfoAXY7ju-12HLFxYb-9mDotjjsiGUZfNSpl90nfpeMBeOO0yagYY92UI9Z8-Uhi0i6PjFICTmviayohuWC1eP_jzOsmRZ_7uBs97qSRCrsftPnUYdvxcOf2sdUPzHTVsww_BlHvy0Nv3zM2Bvji2fLCbaWIx8DGJ-9Cy9k7RA3Btq8o4M4J83td1pNzbTKLsWVg0eVRe4v0f258=w1840-h1228-no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually did some research and turns out linking images from Google Photos like this doesn't last indefinitely so it would be better to use Imgur to host this cover image. We will need to change the other cover images as well but that can def be done in a future PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the album or the image?

Google photos is a bit more profesh and the albums look nicer than imgur pics.

For hosting photos we can also add them to this repo and link to them, maybe as attachments to an issue, or by adding them to the assets folder

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think thats the way to go, storing them locally for all the pics on the site, lets leave the google photos link up for the entire album for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I'm actually just talking about the banner image - we can't directly link images like that - the Google Photo direct image links expire after a certain time.

I like that all the images are hosted on Google Photos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image just needs to be changed to an Imgur one and then I can merge! 🎉

Copy link
Member

@FrancesCoronel FrancesCoronel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just needs two updates.

@fvntr
Copy link
Collaborator Author

fvntr commented Oct 26, 2018

Im going to work on the assets folder

@FrancesCoronel
Copy link
Member

@fvntr No need to add on assets - just wanted to update the banner image. 👍

@fvntr
Copy link
Collaborator Author

fvntr commented Nov 1, 2018

ok working on it

@ghost ghost assigned FrancesCoronel Nov 6, 2018
Copy link
Member

@FrancesCoronel FrancesCoronel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed image URL - LGTM now

@FrancesCoronel FrancesCoronel merged commit 08c6159 into techqueria:master Nov 6, 2018
@ghost ghost removed the review This issue is under review - used by Waffle.io tracker label Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants