add support for dark mode #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossPatton
requested review from
fionaRowan and
shushugah
and removed request for
shushugah
shushugah
approved these changes
Nov 25, 2020
_sass/_variables.scss
Outdated
| $white: #fff; | ||
| $grey: #222; | ||
| $grey2: #444; | ||
| $grey3: #f6f6f6; | ||
| $black: rgb(2, 14, 15); |
There was a problem hiding this comment.
this black will override the $black definition on line 2. One of them should be removed, I'm happy to keep line 7.
There was a problem hiding this comment.
hmm, i'd rather go with line 2 personally. not much difference either way
| @@ -50,6 +37,16 @@ permalink: /nyc/ | |||
|
|
|||
| <hr /> | |||
|
|
|||
| <div class="flex justify-between ai-center pad"> | |||
There was a problem hiding this comment.
ai-center is such an intriguing name!
There was a problem hiding this comment.
atomic class names are just descriptive. sometimes i see this as items-center, but that's all it is. it aligns items along the vertical center
There was a problem hiding this comment.
i'd rather have tailwind just auto-generate all these and never think about css again, personally. for a future version maybe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #250
not exactly the best, but hey, it works
for the svg icons, the reason i embedded them directly so i could take advantage of css classes to change the fill based on theme