Update CI builds to Ubuntu 22.04 / OpenSSL 3 #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By updating the Linux builds to be based on Ubuntu 22.04, this should make the resulting binaries start linking against OpenSSL 3, instead of the end-of-life OpenSSL 1.1.x series. To be confirmed upon analysis of the built artifacts.
|
Looks like there is some new Windows CI issue to work through, but confirmed that the |
This was referenced Sep 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #1092 +/- ##
==========================================
+ Coverage 46.27% 46.29% +0.01%
==========================================
Files 171 171
Lines 65033 65111 +78
==========================================
+ Hits 30093 30142 +49
- Misses 34940 34969 +29
... and 30 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Some pending work surfaced a problem where the icudata link order wasn't correct in some situations. Putting the link ordering hack with the rest of the ICU logic fixes things.
The motivation for this change is to fix the Windows pkg-config CI, where MSYS2's switch to the `pkgconf` implementation of `pkg-config` has surfaced challenges in this crate's build script. But, it is also true that we only need harfbuzz-icu for versions of Harfbuzz that are very old at this point, and separating out that dependency will help us work towards potentially one day being able to swap out the ICU dependency with something else. So it's good to make that jump for bigger reasons than just the CI.
…BUG=true This should compile build deps (but not actual runtime deps) with debug info, proving more info if a build script should happen to panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By updating the Linux builds to be based on Ubuntu 22.04, this should make the resulting binaries start linking against OpenSSL 3, instead of the end-of-life OpenSSL 1.1.x series. To be confirmed upon analysis of the built artifacts.